Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324798 - make task deactivation use a command
Summary: make task deactivation use a command
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.4.2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 16:41 EDT by Sam Davis CLA
Modified: 2010-09-09 18:37 EDT (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (1.15 KB, application/octet-stream)
2010-09-08 16:42 EDT, Sam Davis CLA 		no flags Details
fix (7.91 KB, patch)
2010-09-09 18:35 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (13.67 KB, application/octet-stream)
2010-09-09 18:35 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2010-09-08 16:41:25 EDT 
Task deactivation doesn't use a command, so it is not captured in the event stream.
Comment 1 Sam Davis CLA 2010-09-08 16:42:20 EDT 
Created attachment 178443 [details]
mylyn/context/zip
Comment 2 Shawn Minto CLA 2010-09-08 16:55:55 EDT 
Does this only happen when the task is deactivated from the task list?
Comment 3 Steffen Pingel CLA 2010-09-08 17:25:33 EDT 
Can you be more specific, Sam? The plugin.xml of o.e.m.tasks.ui specifies a command for deactivating the active task. The id is org.eclipse.mylyn.tasks.ui.command.deactivateSelectedTask .
Comment 4 Sam Davis CLA 2010-09-08 18:04:06 EDT 
The command is not used when deactivating the task by clicking the icon in the task list, nor when deactivating a task using the task editor.
Comment 5 Steffen Pingel CLA 2010-09-08 18:13:36 EDT 
Right, can you provide a patch that makes the appropriate changes to ToggleTaskActivationAction etc.? TasksUiInternal.activateTaskThroughCommand() has an example how to programatically invoke a command.
Comment 6 Sam Davis CLA 2010-09-08 18:20:41 EDT 
I'll look into it when I get a chance.
Comment 7 Steffen Pingel CLA 2010-09-09 18:35:14 EDT 
Created attachment 178575 [details]
fix
Comment 8 Steffen Pingel CLA 2010-09-09 18:35:16 EDT 
Created attachment 178576 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2010-09-09 18:37:32 EDT 
Fixed in e_3_4_m_3_x and head. Task deactivation from the editor and task list should now be facilitated through the org.eclipse.mylyn.tasks.ui.command.deactivateSelectedTask command. Shawn, it woulc be nice if you could do a quick review when you get a chance.