Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324776 - MOXy: SchemaGenerator addToSchemaType method needs to be broken apart
Summary: MOXy: SchemaGenerator addToSchemaType method needs to be broken apart
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 13:57 EDT by David McCann CLA
Modified: 2022-06-09 10:24 EDT (History)
0 users

See Also:

Attachments
Contains proposed changes. (90.63 KB, patch)
2010-09-09 11:10 EDT, David McCann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McCann CLA 2010-09-08 13:57:13 EDT 
The addToSchemaType method is over 550 lines long, which makes it very difficult to work with when adding new support or debugging issues.  This method needs to be cleaned up and broken apart into smaller, less verbose methods.

There are also one or more places where we check for a given annotation as opposed to asking the Property.  For XML metadata/annotation correctness we should be checking the property.
Comment 1 David McCann CLA 2010-09-09 11:10:57 EDT 
Created attachment 178523 [details]
Contains proposed changes.

1) Added constants for '@', "##default", etc.
2) Renamed inner class 'XmlPathResult' to 'AddToSchemaResult' and added a ComplexType attribute.
3) Cleaned up 'addToSchemaType' method - new methods were added at the end of the class.
Comment 2 David McCann CLA 2010-09-09 14:08:35 EDT 
Reviewed by:  blaise.doughan@oracle.com
Tests: all unit tests pass as expected
Comment 3 Eclipse Webmaster CLA 2022-06-09 10:24:02 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink