Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324771 - [zOS] Compile error, strcasecmp undefined
Summary: [zOS] Compile error, strcasecmp undefined
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC other
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 13:20 EDT by Mike Reid CLA
Modified: 2016-05-05 11:21 EDT (History)
1 user (show)

See Also:
kathy: pmc_approved? (oec)
kathy: pmc_approved? (ernest)
kathy: pmc_approved? (kathy)
jgwest: pmc_approved+
kathy: pmc_approved? (jerome.bozier)
mikereid: review?

Attachments
Patch (735 bytes, patch)
2010-09-08 13:22 EDT, Mike Reid CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reid CLA 2010-09-08 13:20:53 EDT 
The zOS build requires strings.h to be included from CallGraphProfiler.cpp in order to use the strcasecmp function.
Comment 1 Mike Reid CLA 2010-09-08 13:22:19 EDT 
Created attachment 178425 [details]
Patch

Patch to included strings.h for zOS build
Comment 2 Mike Reid CLA 2010-09-08 13:48:17 EDT 
John can you review the attached patch?
Comment 3 Jonathan West CLA 2010-09-08 14:19:15 EDT 
Patch is good.
Comment 4 Mike Reid CLA 2010-09-08 14:27:07 EDT 
Requesting we bring this forward for PMC approval:

   1.   Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?

Compile error prevents build on other platforms which downstream products may want to ship binaries for.

   2. Is there a work-around? If so, why do you believe the work-around is insufficient?

No.

   3. Is this a regression or API breakage? Explain.

Compile error introduced in recent check-in.

   4. Does this require new API?

No.

   5. Who performed the code review?

Jonathan West

   6. Is there a test case attached to the bugzilla record?

No.

   7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix?

Platform specific #include.

   8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?

No.
Comment 5 Kathy Chan CLA 2010-09-08 14:59:51 EDT 
Requesting PMC approval for TPTP 4.7.1.
Comment 6 Mike Reid CLA 2010-09-08 17:11:21 EDT 
Patch checked into HEAD w/ PMC approval.
Comment 7 Kathy Chan CLA 2011-02-11 13:46:37 EST 
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 8 Mike Reid CLA 2011-04-04 10:53:43 EDT 
Closing.