Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324739 - [historyView] Double-click on file list behaves strange in case of merge commit
Summary: [historyView] Double-click on file list behaves strange in case of merge commit
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Stefan Lay CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 09:32 EDT by Mathias Kinzler CLA
Modified: 2010-10-13 09:43 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Kinzler CLA 2010-09-08 09:32:05 EDT 
When double-clicking on a file in the file list, the behavior is strange in case of a merge commit: if compare mode is on, it shows a comparson of the ancestors of the merge commit; if compare mode is off, it shows the version of one (arbitrary?) ancestor of the merge commit.
We need to think what to do here, as there is no unique ancestor available. Maybe we need to disable the double-click altogether?
Comment 1 Stefan Lay CLA 2010-10-01 05:24:28 EDT 
Double click in compare mode should behave as git log -p -- <path>.
Comment 2 Stefan Lay CLA 2010-10-08 10:17:29 EDT 
Code review at http://egit.eclipse.org/r/#change,1715
Comment 3 Mathias Kinzler CLA 2010-10-13 09:43:50 EDT 
Merged as 7b31f66982887d3439365e14bcaa024bdd6a6d15