Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324736 - [historyView] Commit selection is lost when filter changes
Summary: [historyView] Commit selection is lost when filter changes
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 0.11-M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 09:16 EDT by Stefan Lay CLA
Modified: 2011-08-03 17:26 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Lay CLA 2010-09-08 09:16:56 EDT 
When I change the filter in the histroy view I would expect that the commit selection is preserved if the commit is still in the list. Instead the first commit is selected.
Comment 1 Robin Stocker CLA 2011-05-10 18:38:55 EDT 
Change proposed: http://egit.eclipse.org/r/3383
Comment 2 Matthias Sohn CLA 2011-07-27 18:56:43 EDT 
merged as 20c95604c253c4607472c39af4f030d82aaaf1be
Comment 3 Robin Stocker CLA 2011-08-03 04:02:17 EDT 
Matthias, should we reopen this bug so that the following comment of you can be addressed?:

"""Would be even more useful if the selected commit would stay in the visible area when switching the filter type, similar to what happens when you select a ref (branch, tag etc.) in the repositories view"""

I'll look into it (but my SWT-fu may not be strong enough).
Comment 4 Matthias Sohn CLA 2011-08-03 07:12:00 EDT 
reopened for addressing my comment
Comment 5 Robin Stocker CLA 2011-08-03 12:26:16 EDT 
Pushed http://egit.eclipse.org/r/3955 to address the comment.
Comment 6 Matthias Sohn CLA 2011-08-03 17:26:37 EDT 
merged as 1ac0a293b2e54eebd4d7173ddc29d580e370a7c5