Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324735 - Refactor RWT.NLS
Summary: Refactor RWT.NLS
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 1.5 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 09:04 EDT by Holger Staudacher CLA
Modified: 2011-11-07 08:15 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2010-09-08 09:04:50 EDT 
The RWT.NLS class has two methods which expect both two arguments. The first argument is called bundle name. But the i18n doesn't work when you pass the bundle name. You have to pass the package name ending with the name of the .properties file of your strings. I think the parameters and the description of the parameters should be renamed to avoid miss interpretation.
Comment 1 Ivan Furnadjiev CLA 2010-09-09 08:20:50 EDT 
Bundle means resource bundle - see http://download.oracle.com/javase/1.4.2/docs/api/java/util/ResourceBundle.html. I think that this is the correct naming.
Comment 2 Ralf Sternberg CLA 2010-09-10 08:10:53 EDT 
The original NLS class also uses this variable name. How about changing the Javadoc for this variable to use the term "resource bundle"?
Comment 3 Ivan Furnadjiev CLA 2011-11-07 08:15:04 EST 
(In reply to comment #2)
> How about changing the Javadoc for this variable to use the term "resource bundle"?
Fixed as suggested - using the term "resource bundle" in the JavaDoc.