Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324728 - [ Theme ][ Tree ] Gridlines are overwritten by custom background color
Summary: [ Theme ][ Tree ] Gridlines are overwritten by custom background color
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 1.4 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 320597
  Show dependency tree
 
Reported: 2010-09-08 07:45 EDT by Artur Kronenberg CLA
Modified: 2011-03-22 11:59 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Artur Kronenberg CLA 2010-09-08 07:45:18 EDT 
Currently, when using custom background colors in cells in a table tree the Gridlines are everlayed by the custom background color. They should still be visible like in the case of a regular table.
Comment 1 Tim Buschtoens CLA 2010-09-08 10:36:00 EDT 
The real issue here is that the lines are part of the row and not given additional room by the layout. Since overflow is not set to hidden, the content of the row can overlay the line. However, setting overflow to hidden would have other side-effects, such as cutting of the list pixel-row of icons. So either:

- set overflow to hidden, ignoring the potential cutting of content.
- reduce height of the cell-background, but icons/text can still overlay the line
- respect gridlines in layout (adding 1px to item-height)
Comment 2 Tim Buschtoens CLA 2010-09-08 11:26:07 EDT 
In SWT the space for the gridline seens to be added on top of the content when calculationg the item-height, no matter if its visible or not. Of the line is displayed, it only cuts of the item/cell background, none of the content (there is already enough space).
Comment 3 Tim Buschtoens CLA 2010-09-08 11:42:57 EDT 
Same issue exists for Table (Bug 324759).

I think this also shows that we should merge Tree and Table on the client at some point, they will often have the same issues.
Comment 4 Tim Buschtoens CLA 2011-03-22 11:59:56 EDT 
Fixed in CVS HEAD.

Horizontal gridline is now respected in height calculation for item and cell-background. To compensate for the additional pixel i adjusted the padding in teh default theme so it results in the same height overall.