Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324726 - No content assist possible in single quotes string
Summary: No content assist possible in single quotes string
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Jacek Pospychala CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-08 06:41 EDT by Jacek Pospychala CLA
Modified: 2010-09-28 17:34 EDT (History)
1 user (show)

See Also:
cmjaun: review+
thatnitind: review+

Attachments
patch (1.23 KB, patch)
2010-09-08 06:44 EDT, Jacek Pospychala CLA 		thatnitind: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2010-09-08 06:41:24 EDT 
I'm using org.eclipse.wst.jsdt.ui.javaCompletionProposalComputer extension point to add some cool completion proposals in javascript strings:

<javaCompletionProposalComputer
            activate="true"
            class="jaceks.CoolJCPComputer">
         <partition
               type="__java_string">
         </partition>
         <partition
               type="__java_character">
         </partition>
      </javaCompletionProposalComputer>


This enables content assist in JS files in double-quoted strings ("__java_string"), but unfortunately not in single-quoted strings ("__java_character").
Comment 1 Jacek Pospychala CLA 2010-09-08 06:44:08 EDT 
Created attachment 178382 [details]
patch

Solution that works for me is to use the same ContentAssistProcessor for both __java_character and __java_string partitions.
Previously, no processor was configured for __java_character partition.
Comment 2 Chris Jaun CLA 2010-09-15 14:47:03 EDT 
Patch looks fine to me.

Marked for Nitin's review.

3.2.3 will open up for fixes in a couple weeks.
Comment 3 Nitin Dahyabhai CLA 2010-09-28 17:33:51 EDT 
Applied to HEAD and maintenance.