Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324675 - GroupFilterMappingItemProvider ignores servlet filter mappings
Summary: GroupFilterMappingItemProvider ignores servlet filter mappings
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Dimitar Giormov CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-07 13:15 EDT by Carl Anderson CLA
Modified: 2011-01-29 12:38 EST (History)
2 users (show)

See Also:
dimitar.giormov: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
dimitar.giormov: pmc_approved? (naci.dai)
dimitar.giormov: pmc_approved? (deboer)
dimitar.giormov: pmc_approved? (neil.hauge)
dimitar.giormov: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
Added filtermapping to servlet to show in the DD tree. (1.02 KB, patch)
2011-01-19 09:58 EST, Dimitar Giormov CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Anderson CLA 2010-09-07 13:15:47 EDT 
In GroupFilterMappingItemProvider.getFilterMappingDisplay(), if the filter mapping is based on a servlet name instead of a URL mapping, it is discarded.  We should show these filter mappings in the Project Explorer.
Comment 1 Carl Anderson CLA 2010-09-07 13:16:33 EDT 
I am assigning this to Kaloyan for initial investigation.
Comment 2 Dimitar Giormov CLA 2011-01-19 09:58:31 EST 
Created attachment 187110 [details]
Added filtermapping to servlet to show in the DD tree.
Comment 3 Dimitar Giormov CLA 2011-01-19 09:59:03 EST 
Chuck can you review the patch?
Comment 4 Chuck Bridgham CLA 2011-01-25 14:33:21 EST 
approve
Comment 5 Dimitar Giormov CLA 2011-01-26 02:43:38 EST 
Dear PMC members,

This bug causes incomplete representation of the Web model in the deployment descriptor tree. Till now the filter mappings that point to servlet were ignored and not shown.
There is a workaround to check the web.xml
The fix is tested manually. Chuck has reviewed the change.
Risk: Low

Technical details:
The fix actually adds the filter mappings that point to servlet to the list with the mappings that point to URL in the appropriate format.
Comment 6 Carl Anderson CLA 2011-01-27 14:46:46 EST 
Committed to R3_2_maintenance for WTP 3.2.3