324669 – [dstore] IBM-eucJP to UTF-8 char conversion appends nulls to end of file during text-mode download

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 324669 - [dstore] IBM-eucJP to UTF-8 char conversion appends nulls to end of file during text-mode download

Summary: [dstore] IBM-eucJP to UTF-8 char conversion appends nulls to end of file duri...

Reported:	2010-09-07 12:01 EDT by David McKnight
Modified:	2010-11-09 08:16 EST (History)
CC List:	0 users

See Also:

Flags:	mober.at+eclipse: pmc_approved+ dmcknigh: review? (kjdoyle)

Attachments
patch to write byte array up to the limit rather than the entire array (2.13 KB, patch) 2010-09-07 12:04 EDT, David McKnight	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David McKnight

2010-09-07 12:01:05 EDT

When downloading an IBM-eucJP file to a UTF-8 workspace, unwanted nulls can be appended to the resulting file.

Comment 1 David McKnight

2010-09-07 12:04:25 EDT

Created attachment 178337 [details]
patch to write byte array up to the limit rather than the entire array

Comment 2 David McKnight

2010-09-07 12:04:57 EDT

Kevin, could you please review this patch?

Comment 3 David McKnight

2010-09-07 12:58:35 EDT

If possible I'd like to get this into the release since the problem effects our product and the change is trivial.

Comment 4 Martin Oberhuber

2010-09-08 04:11:16 EDT

+1 looks good to me, please commit.

Comment 5 David McKnight

2010-09-08 07:26:48 EDT

Thanks for the review, Martin.  I've committed the change to cvs.

Comment 6 Martin Oberhuber

2010-09-09 13:35:40 EDT

Released, please test with the next M-Build (should be M20100909-1340).
Please set the bug VERIFIED when OK.

Comment 7 Martin Oberhuber

2010-11-09 08:16:16 EST

Verified that this has been released to 3.3m3 as well.