Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324651 - [Tree] grid lines not correctly drawn when scrolling horizontally
Summary: [Tree] grid lines not correctly drawn when scrolling horizontally
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 320597
  Show dependency tree
 
Reported: 2010-09-07 08:54 EDT by Bogdan B. CLA
Modified: 2010-09-08 07:37 EDT (History)
4 users (show)

See Also:

Attachments
Code snippet producing the error (2.12 KB, text/x-java)
2010-09-07 08:58 EDT, Bogdan B. CLA 		no flags Details
Screen shot of the error (146.85 KB, image/jpeg)
2010-09-07 09:01 EDT, Bogdan B. CLA 		no flags Details
Proposed patch (1.01 KB, patch)
2010-09-07 09:44 EDT, Ivan Furnadjiev CLA 		no flags Details | Diff
Code snippet producing the error - added cell editor test (6.78 KB, text/x-java)
2010-09-07 11:32 EDT, Bogdan B. CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bogdan B. CLA 2010-09-07 08:54:46 EDT 
Build Identifier: RAP 1.4M1

The 1.4M1 implementation of the Tree widget does not draw the grid lines correctly (it gathers them together to the left) when the tree has many columns (let's say 20) and scrolling horizontally to the right.
I shall post in short time a code snippet and a screen shot demonstrating the problem.

I tested with Firefox 3.6.8 under Windows XP.

Maybe this is related also with Bug #313569 ?!

Reproducible: Always

Steps to Reproduce:
1. Create a tree with 20 columns
2. Scroll to the right
Comment 1 Bogdan B. CLA 2010-09-07 08:58:26 EDT 
Created attachment 178314 [details]
Code snippet producing the error
Comment 2 Bogdan B. CLA 2010-09-07 09:01:15 EDT 
Created attachment 178315 [details]
Screen shot of the error
Comment 3 Ivan Furnadjiev CLA 2010-09-07 09:08:56 EDT 
Reproducible with Controls Demo -> TreeTab too. Just change INITIAL_COLUMNS from 5 to 25 for example. Tested with FF 3.6.8 and IE8.
Comment 4 Ivan Furnadjiev CLA 2010-09-07 09:44:44 EDT 
Created attachment 178322 [details]
Proposed patch
Comment 5 Bogdan B. CLA 2010-09-07 11:32:35 EDT 
Created attachment 178333 [details]
Code snippet producing the error - added cell editor test

I added a cell editor test to the original snippet (which I marked as obsolete), just to be sure the bounds of the editor widgets are correctly calculated. Please test the patch with it!
Comment 6 Bogdan B. CLA 2010-09-07 11:43:18 EDT 
What to test in the UI showed by this snippet:
1) double click in a cell should activate a cell editor rendered by a simple Composite. Additionally, just to be sure the boundaries are correct, a PopupDialog is opened having its top left corner exactly in the same Point as the top left corner of the cell editor Composite.
2) swap 2 cells without scrolling right and double click in their cells to test the editors
3) scroll right and double click in a cell - the editor is not correctly positioned (should be with your patch)
4) also double click to test editors after scrolling right.
Comment 7 Ivan Furnadjiev CLA 2010-09-08 02:42:17 EDT 
Bogdan, I don't understand the relation between cell editor and grid lines positioning when scrolling. Maybe you mismatch this bug with bug 321489 :-)
Comment 8 Bogdan B. CLA 2010-09-08 03:36:50 EDT 
Yes, I tested both with this one snippet.
I just wanted to make sure that when you fix the grid lines by scrolling, the editors are also shown correctly. Because I really need it for M2.
Comment 9 Tim Buschtoens CLA 2010-09-08 07:37:51 EDT 
Applied patch as-is to CVS HEAD and added a test.