Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324625 - Ant editor does not support the "extension-point" feature
Summary: Ant editor does not support the "extension-point" feature
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 3.8 M2   Edit
Assignee: Satyam Kandula CLA
QA Contact:
URL:
Whiteboard: readme
Keywords:
: 359456 (view as bug list)
Depends on: 302296
Blocks:
  Show dependency tree
 
Reported: 2010-09-07 04:21 EDT by Andrey Pavlenko CLA
Modified: 2011-09-29 22:14 EDT (History)
5 users (show)

See Also:
Michael_Rennie: review+

Attachments
Patch for ant1.6.2.dtd (3.80 KB, patch)
2010-09-07 04:27 EDT, Andrey Pavlenko CLA 		no flags Details | Diff
A patch (20.16 KB, patch)
2011-07-28 12:29 EDT, Satyam Kandula CLA 		no flags Details | Diff
Proposed patch + regression test (20.81 KB, patch)
2011-08-01 07:42 EDT, Satyam Kandula CLA 		no flags Details | Diff
Proposed patch + regression test (20.82 KB, text/plain)
2011-08-02 12:13 EDT, Satyam Kandula CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Pavlenko CLA 2010-09-07 04:21:01 EDT 
Build Identifier: 3.6.0

The Ant Editor does not support the "extension-point" feature, introduced in Ant 1.8. This functionality is required for Ant 1.8.* and Eclipse integration (https://bugs.eclipse.org/bugs/show_bug.cgi?id=302296).

Reproducible: Always

Steps to Reproduce:
1. Install org.apache.ant_1.8.1.zip from https://bugs.eclipse.org/bugs/show_bug.cgi?id=302296
2. Execute the following build script:

<project default="ep-B">

    <target name="A" />

    <extension-point name="ep-B" depends="A" />

    <target name="B" extensionOf="ep-B" depends="D" />

    <target name="C" depends="ep-B" />

    <target name="D" />

</project>
Comment 1 Andrey Pavlenko CLA 2010-09-07 04:27:27 EDT 
Created attachment 178301 [details]
Patch for ant1.6.2.dtd

This patch covers the content assist related issue.
Comment 2 Satyam Kandula CLA 2011-07-28 12:29:37 EDT 
Created attachment 200545 [details]
A patch

Michael, Please look at the patch and give me your comments.
Comment 3 Satyam Kandula CLA 2011-08-01 07:42:04 EDT 
Created attachment 200651 [details]
Proposed patch + regression test

This patch also fixes Shift+F2 on extension-point also. 
Also note that both this patch and the patch in comment 2 are on top of the patch given in comment 1. 

With this patch, I think the only left over now is having a template for extension-point.
Comment 4 Michael Rennie CLA 2011-08-02 11:12:51 EDT 
The patch works nicely. The only issue I found was that you do not get a completion proposal for "extension-point" when you activate content assist on a blank line.

Consider the following example:

<?xml version="1.0" encoding="UTF-8"?>
<project name="project" default="default">
    <description>
            test project
    </description>
  
    <target name="default" description="test target">
    </target>
</project>

Steps
1. place the caret on line 6 (the blank line)
2. do not type anything
3. activate content assist
4. start typing extension-point

I would expect one of the proposals to be 'extension-point'.
Comment 5 Satyam Kandula CLA 2011-08-02 12:03:11 EDT 
(In reply to comment #4)
Mike, nice-catch. I will update a new patch shortly.
Comment 6 Satyam Kandula CLA 2011-08-02 12:13:17 EDT 
Created attachment 200745 [details]
Proposed patch + regression test

Updated the fix to support getting the extension-point in the content-assist.
Comment 7 Michael Rennie CLA 2011-08-08 12:02:23 EDT 
Works perfectly. Applied to HEAD.
Comment 8 Michael Rennie CLA 2011-08-08 12:02:36 EDT 
verified.
Comment 9 Satyam Kandula CLA 2011-09-29 22:14:21 EDT 
*** Bug 359456 has been marked as a duplicate of this bug. ***