Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324571 - [build] Bad string comparison using !=
Summary: [build] Bad string comparison using !=
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh All
: P3 trivial (vote)
Target Milestone: 0.7   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-06 08:07 EDT by Torkild Resheim CLA
Modified: 2011-01-05 14:44 EST (History)
0 users

See Also:

Attachments
Patch to fix the issue (782 bytes, patch)
2010-09-06 08:10 EDT, Torkild Resheim CLA 		steffen.pingel: iplog+
Details | Diff
mylyn/context/zip (980 bytes, application/octet-stream)
2010-09-06 08:10 EDT, Torkild Resheim CLA 		no flags Details
mylyn/context/zip (1.00 KB, application/octet-stream)
2010-09-07 19:33 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torkild Resheim CLA 2010-09-06 08:07:55 EDT 
org.eclipse.mylyn.internal.builds.BuildImages contains a bad string comparison.
Comment 1 Torkild Resheim CLA 2010-09-06 08:10:29 EDT 
Created attachment 178262 [details]
Patch to fix the issue

Uses String.equals() instead of "".
Comment 2 Torkild Resheim CLA 2010-09-06 08:10:31 EDT 
Created attachment 178263 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2010-09-07 19:33:07 EDT 
Thanks for pointing that out. I have removed the bogus check all together and made a similar change in the equivalent implementations in Bugzilla and Trac.
Comment 4 Steffen Pingel CLA 2010-09-07 19:33:38 EDT 
Created attachment 178368 [details]
mylyn/context/zip