Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324570 - [build] use toString() methods to create strings from primitives instead of appending empty strings
Summary: [build] use toString() methods to create strings from primitives instead of a...
Status: RESOLVED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-06 07:57 EDT by Torkild Resheim CLA
Modified: 2010-11-12 12:31 EST (History)
0 users

See Also:

Attachments
Patch to fix the issue (1.42 KB, patch)
2010-09-06 08:05 EDT, Torkild Resheim CLA 		no flags Details | Diff
mylyn/context/zip (7.69 KB, application/octet-stream)
2010-09-06 08:05 EDT, Torkild Resheim CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torkild Resheim CLA 2010-09-06 07:57:52 EDT 
I see code where <int value> + "" is used to produce a string instead of Integer.toString(<int value>).  The latter is more readable and also faster.
Comment 1 Torkild Resheim CLA 2010-09-06 08:05:42 EDT 
Created attachment 178259 [details]
Patch to fix the issue

Replaces <int value>+"" with Integer.toString(<int value>).
Comment 2 Torkild Resheim CLA 2010-09-06 08:05:44 EDT 
Created attachment 178260 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2010-09-07 19:14:32 EDT 
I understand that you prefer a different style but unless there is a measurable performance impact I won't apply this change. The overhead for tracking the IP log entry outweighs the benefit.
Comment 4 Torkild Resheim CLA 2010-09-08 01:54:17 EDT 
The performance impact of using toString() instead of <string>+"" is measurable. The prior takes about half the time. But I doubt that it is noticeable in this case. I'm OK with resolving the bug as WONTFIX.