Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324540 - The workspace should play nice with EFS and pass non-null progress monitors
Summary: The workspace should play nice with EFS and pass non-null progress monitors
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-05 15:14 EDT by Eike Stepper CLA
Modified: 2020-03-22 06:51 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2010-09-05 15:14:05 EDT
I've created a (possibly non-exclusive) list of places where I see null or NullProgressMonitor being passed down to an EFS method that offers to take a proper progress monitor:

org.eclipse.core.filesystem.URIUtil.toPath(URI)
org.eclipse.core.filesystem.provider.FileStore.copyDirectory(IFileInfo, IFileStore, int, IProgressMonitor)
org.eclipse.core.filesystem.provider.FileStore.copyFile(IFileInfo, IFileStore, int, IProgressMonitor)
org.eclipse.core.filesystem.provider.FileStore.fetchInfo()
org.eclipse.core.filesystem.provider.FileStore.transferAttributes(IFileInfo, IFileStore)
org.eclipse.core.internal.filesystem.FileCache.cleanOldCache(File)
org.eclipse.core.internal.localstore.BlobStore.addBlob(IFileStore, boolean)
org.eclipse.core.internal.localstore.BlobStore.deleteBlob(UniversalUniqueIdentifier)
org.eclipse.core.internal.localstore.BlobStore.getBlob(UniversalUniqueIdentifier)
org.eclipse.core.internal.localstore.FileStoreRoot.toLocalPath(URI)
org.eclipse.core.internal.localstore.FileSystemResourceManager.doGetEncoding(IFileStore)
org.eclipse.core.internal.localstore.FileSystemResourceManager.getFileURI(URI)
org.eclipse.core.internal.localstore.FileSystemResourceManager.setLocalTimeStamp(IResource, ResourceInfo, long)
org.eclipse.core.internal.localstore.FileSystemResourceManager.setResourceAttributes(IResource, ResourceAttributes)
org.eclipse.core.internal.localstore.FileSystemResourceManager.write(IFile, InputStream, IFileInfo, int, boolean, IProgressMonitor)
org.eclipse.core.internal.localstore.FileSystemResourceManager.writeSilently(IProject)
org.eclipse.core.internal.localstore.UnifiedTree.getLocalList(UnifiedTreeNode)
org.eclipse.core.internal.localstore.UnifiedTree.initLinkHistoriesIfNeeded()
org.eclipse.core.internal.localstore.UnifiedTree.isRecursiveLink(IFileStore, IFileInfo)
org.eclipse.core.internal.resources.ContentDescriptionManager.LazyFileInputStream.ensureOpened()
org.eclipse.core.internal.resources.ResourceTree.internalDeleteProject(IProject, int, IProgressMonitor)
org.eclipse.core.internal.resources.ResourceTree.movedProjectSubtree(IProject, IProjectDescription)
org.eclipse.core.internal.resources.ResourceTree.standardDeleteProject(IProject, int, IProgressMonitor)
org.eclipse.core.internal.resources.ResourceTreeorg.eclipse.core.filesystem.provider.FileStore.copy(IFileStore, int, IProgressMonitor)

I'm trying to implement a file system and I find it hard to report progress or react to cancelation if I'm not passed a monitor.

The above list is based on these versions:

org.eclipse.core.filesystem_1.3.0.v20100526-0737
org.eclipse.core.resources_3.6.0.v20100526-0737
Comment 1 Alain Picard CLA 2011-09-24 20:35:40 EDT
similar to Bug 253768 and could be fixed the same way by changing UnifiedTree
Comment 2 Eclipse Genie CLA 2020-03-22 06:51:49 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.