Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324518 - [Duplicate] ListDifferenceAnalyzer.createListChanges passes wrong value to createRemoveListChange
Summary: [Duplicate] ListDifferenceAnalyzer.createListChanges passes wrong value to cr...
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Core (show other bugs)
Version: 2.7.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ed Merks CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 308618
Blocks:
  Show dependency tree
 
Reported: 2010-09-04 12:54 EDT by Ed Merks CLA
Modified: 2010-11-05 05:41 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Merks CLA 2010-09-04 12:54:54 EDT 
+++ This bug was initially created as a clone of Bug #308618 +++

Build Identifier: 3.5.1

In ListDifferenceAnalyzer.createListChanges in case of a remove, a wrong remove-value or null is passed to the createRemoveListChange method.

The ListChange objects do not make use of the value passed, so it's not a problem for EMF. However, CDORevisionDeltaImpl overwrites the createRemoveListChange method and uses the value passed to build the revision deltas. One could always get the correct value by using the oldList and index passed though, but it would probably be nice to have the correct value passed as well.

Reproducible: Always
Comment 1 Ed Merks CLA 2010-09-04 12:58:47 EDT 
The fix is committed to CVS for 2.7.
Comment 2 Ed Merks CLA 2010-11-05 05:41:30 EDT 
The fix is available in the latest build for the stream.