Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324494 - [e4] builds and team repositories views do not have popup menus
Summary: [e4] builds and team repositories views do not have popup menus
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.5   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 321278 336432
  Show dependency tree
 
Reported: 2010-09-03 16:23 EDT by Steffen Pingel CLA
Modified: 2011-08-18 07:06 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2010-09-03 16:23:55 EDT
The popup menus in the viewers do not appear on right click.
Comment 1 Steffen Pingel CLA 2010-10-18 17:51:46 EDT
Here is what the code looks like. When the view is created the popup menu is registered and a number of separators are added:

	protected void createPopupMenu(Composite parent) {
		MenuManager menuManager = new MenuManager();

		menuManager.add(new GroupMarker("group.open"));
		menuManager.add(new Separator("group.edit"));
		menuManager.add(new Separator("group.file"));
		menuManager.add(new Separator("group.run"));
		menuManager.add(new Separator("group.refresh"));
		menuManager.add(new Separator(IWorkbenchActionConstants.MB_ADDITIONS));
		menuManager.add(new Separator(BuildsUiConstants.GROUP_PROPERTIES));

		Menu contextMenu = menuManager.createContextMenu(parent);
		viewer.getTree().setMenu(contextMenu);
		getSite().registerContextMenu(menuManager, viewer);
	}

In the plugin.xml commands are registered:

 <extension
       point="org.eclipse.ui.menus">
    <menuContribution
          locationURI="popup:org.eclipse.mylyn.builds.navigator.builds?after=group.run">
       <command
             commandId="org.eclipse.mylyn.builds.ui.command.RunBuild"
             label="Run Build"
             style="push">
       </command>
    </menuContribution>
 </extension>

This "Run Build" menu item shows on Eclipse 3.x but not on e4 (I20100922-0843). If I remove "?after=group.run" from the extensions the item shows on e4 as well so somehow the groups get lost from the menu.

Shawn has reported that it always works on Windows.

Eric, do you have any thoughts what could be causing this?
Comment 2 Steffen Pingel CLA 2010-10-19 02:10:12 EDT
Might be related to bug 325390.
Comment 3 Steffen Pingel CLA 2010-12-16 06:49:07 EST
Seems to be fixed in 4.1M4.