Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324433 - No welcome screen for JavaScript IDE
Summary: No welcome screen for JavaScript IDE
Status: RESOLVED FIXED
Alias: None
Product: EPP
Classification: Technology
Component: javascript-package (show other bugs)
Version: 1.3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.3.0   Edit
Assignee: Markus Knauer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 317354 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-03 10:58 EDT by David Williams CLA
Modified: 2010-11-11 21:09 EST (History)
2 users (show)

See Also:

Attachments
patch to add "universal" intro (8.52 KB, patch)
2010-09-08 01:31 EDT, David Williams CLA 		no flags Details | Diff
modified patch that changes welcome screen to universal (3.51 KB, patch)
2010-09-08 04:05 EDT, Markus Knauer CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2010-09-03 10:58:09 EDT 
Are all EPP packages supposed to have a welcome page? The JavaScript package does not. This was probably true also in initial release, but I've just noticed this in SR1 RC2. 

Not an urgent issue ... it would just be the generic one that comes with the Eclipse SDK ... but ... for consistency, if all other packages do, seems JavaScript should as well. 

This might have been caused by using copy of things from JEE package initially, which does have a custom welcome screen, which would not exist in JavaScript package? Perhaps too, it's related to the fact that it does not have (or prereq) the "whole" Eclipse SDK?
Comment 1 Nitin Dahyabhai CLA 2010-09-06 04:10:29 EDT 
*** Bug 317354 has been marked as a duplicate of this bug. ***
Comment 2 David Williams CLA 2010-09-08 01:31:10 EDT 
Created attachment 178370 [details]
patch to add "universal" intro

This is my best guess as to what "JavaScript" needs to have a "universal" into, similar to other packages that do not have their own custom intro. 

I'm just "going by example" here without much understanding. That is, there'd be some moderate risk applying this to service release (risk it wouldn't work, or we'd have to revert if not correct) ... but I'm game if Markus and Nitin are.
Comment 3 David Williams CLA 2010-09-08 01:32:31 EDT 
Markus, will assign to you ... since I think up to you if you want to try applying this for Helios SR1. I'd sort of like to, just to see if it works ... but you might know more about it than I do.
Comment 4 Markus Knauer CLA 2010-09-08 04:05:23 EDT 
Created attachment 178374 [details]
modified patch that changes welcome screen to universal

This is a patch with some minor changes compared to the first patch.

* patch for the HELIOS branch only (i.e. doesn't change the about dialog texts because it is not necessary)
* includes the referenced intro-eclipse.png

This patch has been applied to the HELIOS branch. If it looks good, I will apply it to CVS HEAD (Indigo) as well. Until then I leave the bug open.
Comment 5 David Williams CLA 2010-09-10 00:04:11 EDT 
This looks good to me (from 9/9 nightly) except I don't see any "samples" in the samples page. Doing a search on "samples" of other packages didn't reveal anything special. Do other packages have samples? I'd think the SWT ones would still be possible ... but not sure how those get added. Maybe from some plugin we don't "include"?
Comment 6 David Williams CLA 2010-09-29 02:35:48 EDT 
(In reply to comment #4)

> 
> This patch has been applied to the HELIOS branch. If it looks good, I will
> apply it to CVS HEAD (Indigo) as well. Until then I leave the bug open.

Let's go ahead and apply to Indigo. For M2, please?
Comment 7 David Williams CLA 2010-11-11 21:09:09 EST 
Fixed in Indigo M3 (as well as service release)