Community
Participate
Working Groups
Follow-up to bug 280801 (AnonymousTypeCompletionProposal 1.93) public class Try { void foo(Object o) { take(null, (String) o); } private void take(Runnable r, String s) { } } Replace 'null' with 'new Runna' and accept the proposal. Result: take(new Runnable() { @Override public void run() { // TODO Auto-generated method stub } };,, (String) o); // too much ^^
> };,, (String) o); > // too much ^^ Grr.., I meant: };,, (String) o); too much ^^ This heuristic will continue to cause trouble. I saw that AnonymousTypeCompletionProposal#createNewBody(..) already creates an AST, and I think that should be used to find out whether the enclosing statement is missing a ';' or not. Even harder example: take(null, (String) o);
I've fixed the ',' case. We can see whether more work is needed in the future but at this time I don't have time to rewrite the heuristic based on the AST. Please reopen if you have more cases that disturb you in your daily work.
Fix is in AnonymousTypeCompletionProposal.
Verified in I20100914-0100.
(In reply to comment #2) > Please reopen if you have more cases that disturb you in your daily work. Not during daily work but while verifying bug 292087 I came across this: Before completion: class Bug324391 { private Runnable jobs[] = { new Run| }; } After completion: class Bug324391 { private Runnable jobs[] = { new Runnable() { @Override public void run() { // TODO Auto-generated method stub } }; }; } Compiler says: Syntax error on token ";", , expected
.
Please file a new bug.
