Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324385 - [search] Double-click in Search results pages should always toggle expansion
Summary: [search] Double-click in Search results pages should always toggle expansion
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X
: P3 minor (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-03 05:17 EDT by Markus Keller CLA
Modified: 2010-10-12 07:01 EDT (History)
2 users (show)

See Also:

Attachments
Fix (1.03 KB, patch)
2010-09-03 05:17 EDT, Markus Keller CLA 		no flags Details | Diff
Complete undo (3.07 KB, patch)
2010-10-12 07:00 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-09-03 05:17:14 EDT 
Created attachment 178126 [details]
Fix

HEAD

Double-click in Search results pages should always toggle expansion.
Comment 1 Markus Keller CLA 2010-09-03 05:17:49 EDT 
Fixed in HEAD.
Comment 2 Deepak Azad CLA 2010-10-12 05:52:36 EDT 
This new behavior is a bit confusing as the double click now does 2 things.
- Everywhere else (package explorer, call hierarchy view) double click just opens the editor, hence as a user I am used to this behavior
- Secondly, once a search result is expanded and you double click to open the editor, the expansion state toggles => as a user you may or may not want this.
Comment 3 Markus Keller CLA 2010-10-12 07:00:29 EDT 
Created attachment 180658 [details]
Complete undo

The TOC in the Eclipse help also does both on double-click (but it already opens the page on single-click). But I agree that in the Search view, the collapsing is confusing now, and since having this feature only for expansion is also confusing, I'll revert the changes.

The attached fix was not complete. Here's the complete patch to undo all changes.
Comment 4 Markus Keller CLA 2010-10-12 07:01:06 EDT 
Reverted in HEAD.