Community
Participate
Working Groups
As per bug 295671, the existing workbench deadlock detection will easily show false positives on fairly simple applications. Deadlocks themselves are fairly serious, as they imply that the involved threads will not come unblocked (without intervention. This bug has been opened to contribute a workaround which disables deadlock detection for 4.7.1. False-positives are worse than false-negatives, as in this case, false positives may cause users to spend a great deal of time on a wild goose chase looking a deadlock that likely doesn't actually exist.
Created attachment 178369 [details] Patch to XMLmonContendedEnterLoader
Mike, can you review? Thanks!
Looks good. The patch introduces a bit of over-indented code down at the bottom of updateDeadlockBy
Accidentally hit enter, my full comment was to be: Looks good. The patch introduces a bit of over-indented code down at the bottom of updateDeadLockByContagion() that you may want to fix up. Otherwise all is well.
Thanks Mike! The entire file has weird indentation, which will all be tossed out when bug 295671 is fixed.
I would like to ask for PMC approval to include the fix of this bug in TPTP v4.7.1. 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? As per bug 295671, the existing workbench deadlock detection will easily show false positives on fairly simple applications. False-positives are worse than false-negatives, as in this case, false positives may cause users to spend a great deal of time on a wild goose chase looking a deadlock that likely doesn't actually exist. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. Not a regression. 4. Does this require new API? No. 5. Who performed the code review? Mike Reid 6. Is there a test case attached to the Bugzilla record? No. 7. What is the nature of the fix? What is the scope of the fix? What is the risk associated with this fix? Fix is a workaround that disables the creation of dead lock events, while maintaining the existing logic for non-deadlock related code. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? n/a
Requesting approval for TPTP 4.7.1.
Patch checked into HEAD w/ PMC approval.
This defect had been resolved as FIXED for more than 1 month. Please verify with the latest TPTP 4.7.2 driver. If this defect is still left unverified by February 25, we'll close it on the originator's behalf. TPTP 4.7.2 driver can be downloaded from: http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Closing.
