Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324325 - Update trace model resource interaction customization
Summary: Update trace model resource interaction customization
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Joel Cayne CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-02 12:01 EDT by Joel Cayne CLA
Modified: 2016-05-05 11:07 EDT (History)
3 users (show)

See Also:
jgwest: pmc_approved? (kathy)
ernest: pmc_approved+
jgwest: pmc_approved? (jerome.bozier)
jgwest: pmc_approved+
jgwest: pmc_approved? (oec)
mikereid: review+

Attachments
Patch for updating loading and deletion (4.57 KB, patch)
2010-09-02 12:04 EDT, Joel Cayne CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Cayne CLA 2010-09-02 12:01:56 EDT 
In Bug 322951 trace model resource interaction customization was added. Some minor updates are required to check the matching process is used for the agent proxy and node, and to allow the delete action to clean up when the XMI files are not removed.
Comment 1 Joel Cayne CLA 2010-09-02 12:04:45 EDT 
Created attachment 178058 [details]
Patch for updating loading and deletion
Comment 2 Joel Cayne CLA 2010-09-02 12:22:20 EDT 
Mike,

Can you please review?

Thanks!
Comment 3 Mike Reid CLA 2010-09-02 12:40:21 EDT 
Looks good.
Comment 4 Joel Cayne CLA 2010-09-02 12:54:52 EDT 
I would like to request for PMC approval to include the fix of this bug in TPTP
v4.7.1.

1.   Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

Updates conditions used to create the Agent Proxy and Node, and handling of deletion for the Trace model interaction customization. 

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

3. Is this a regression or API breakage? Explain.

No.

4. Does this require new API?

n/a

5. Who performed the code review?

Mike

6. Is there a test case attached to the bugzilla record?

No. Tested using the extension point.

7. What is the nature of the fix? What is the scope of the fix? What is the
risk associated with this fix?

Low. Only used by contributors of the extension point.

8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?
n/a
Comment 5 Jonathan West CLA 2010-09-02 12:56:51 EDT 
Requesting approval for TPTP 4.7.1.
Comment 6 Joel Cayne CLA 2010-09-02 13:08:08 EDT 
Patch checked into HEAD with Platform Project and PMC approval.
Comment 7 Joel Cayne CLA 2010-10-04 08:49:34 EDT 
Closing.