Community
Participate
Working Groups
We now always set breakpoints using the -f option so that the bp is kept as pending if the source code is not loaded yet. The problem is that once the code is loaded, GDB activates the pending breakpoint, but we don't reflect that with the installed marker (little checkmark) in Eclipse. The proposed solution can be found in bug 248595 comment #8. Also, there is an improvement being worked on in GDB to have a new MI event that will tell the frontend that a breakpoint has become active. Please see: http://dev.eclipse.org/mhonarc/lists/cdt-dev/msg20196.html
Breakpoint notifications are available since GDB 7.4 which will allow us to know when a breakpoint has gone from pending to enabled.
Hi Mikhail, just a reminder, if you have time, to post the beginnings of the patch you have for this fix. Thanks! Marc
(In reply to comment #2) > Hi Mikhail, > > just a reminder, if you have time, to post the beginnings of the patch you > have for this fix. > > Thanks! > > Marc Sorry Marc, I have completely forgotten about this patch. Will do it today.
(In reply to comment #3) > (In reply to comment #2) > > Hi Mikhail, > > > > just a reminder, if you have time, to post the beginnings of the patch you > > have for this fix. > > > > Thanks! > > > > Marc > > Sorry Marc, I have completely forgotten about this patch. Will do it today. Marc, I am having trouble to make my example working. I can step into the dll's code but I don't get notifications from gdb the pending breakpoint is set. I get notifications (=breakpoint-modified and =breakpoint-deleted) for temporary breakpoint so it is supported by gdb (I am using 7.4). But I don't get any notification for the breakpoint set in the dll. The same example worked a couple of years ago. Do you want me to push the patch to Gerrit anyway?
(In reply to comment #4) > Marc, I am having trouble to make my example working. I can step into the > dll's code but I don't get notifications from gdb the pending breakpoint is > set. I get notifications (=breakpoint-modified and =breakpoint-deleted) for > temporary breakpoint so it is supported by gdb (I am using 7.4). But I don't > get any notification for the breakpoint set in the dll. The same example > worked a couple of years ago. Do you want me to push the patch to Gerrit > anyway? If it's ok with you, I'll take whatever you have. It will still save me time. I'll just build on top of yours. I'll have to figure out how to deal with a double commit with Gerrit though... Not sure yet how I can handle this.
Created attachment 220950 [details] Proposed fix.
(In reply to comment #5) > If it's ok with you, I'll take whatever you have. It will still save me > time. I'll just build on top of yours. I'll have to figure out how to deal > with a double commit with Gerrit though... Not sure yet how I can handle > this. Not sure I understand what you mean by "double commit". Attaching the patch in case if pushing it to Gerrit is a problem.
(In reply to comment #7) > (In reply to comment #5) > > If it's ok with you, I'll take whatever you have. It will still save me > > time. I'll just build on top of yours. I'll have to figure out how to deal > > with a double commit with Gerrit though... Not sure yet how I can handle > > this. > > Not sure I understand what you mean by "double commit". Attaching the patch > in case if pushing it to Gerrit is a problem. Thanks! I don't want to handle this fix as a single commit, or else it won't reflect what you did. I was planning on taking your patch, committing in locally in my repo and then doing a second commit on top of it to complete the work. That should all work with Git but I don't know how to handle it in Gerrit for review.
(In reply to comment #8) > I don't want to handle this fix as a single commit, or else it won't reflect > what you did. I was planning on taking your patch, committing in locally in > my repo and then doing a second commit on top of it to complete the work. > That should all work with Git but I don't know how to handle it in Gerrit > for review. Neither do I. Do you still want me to push it to Gerrit? Regarding the patch, as far as I remember you wanted me to move the notification handling to the breakpoint service instead of MIBreakpointsManager. I remember trying it and realizing that it would require too many modifications.
(In reply to comment #9) > Neither do I. Do you still want me to push it to Gerrit? No, I'll use from here and figure what to do about Gerrit when I get there. Worst case is that we can use Gerrit for review but commit directly to Git to keep both commits visible. > Regarding the patch, as far as I remember you wanted me to move the > notification handling to the breakpoint service instead of > MIBreakpointsManager. I remember trying it and realizing that it would > require too many modifications. Ok, I'll keep this in mind. Thanks again.
This might have been fixed by bug 392512 if someone wants to try it. At a minimum, the work needed now must be very small.
I tried loading a shared lib with a breakpoint set and the 'installed' decorator properly appeared. So this bug was fixed by Mikhail's fix to bug 392512.
(In reply to Marc Khouzam from comment #12) > I tried loading a shared lib with a breakpoint set and the 'installed' > decorator properly appeared. So this bug was fixed by Mikhail's fix to bug > 392512. I was surprised to see this bug still open but didn't have time to check. Sorry for late reaction, it's a public holiday today in Ontario.
