Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324260 - Continuation compatibility broken for use with jetty-6
Summary: Continuation compatibility broken for use with jetty-6
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 7.1.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 7.1.x   Edit
Assignee: Greg Wilkins CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 20:32 EDT by Jan Bartel CLA
Modified: 2010-09-01 21:41 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Bartel CLA 2010-09-01 20:32:08 EDT 
The jetty-continuation ContinuationFilter does not appear to be working correctly when deployed on jetty-6.

The scenario:

Deploy the jetty-7 ProxyServlet and configure the ContinuationFilter on jetty-6. Requests to the ProxyServlet hit the proxied server and the reply comes back just fine, yet the ProxyServlet always returns 504 Gateway Timeout to the requestor.

The only place this happens in the ProxyServlet code is when a Continuation is replayed and we check continuation.isInitial(). In fact, as the proxy request completes ok, and calls continuation.complete() the Continuation should not be replayed into the servlet.
Comment 1 Greg Wilkins CLA 2010-09-01 21:41:05 EDT 
The jetty-6 continuation handling was still allowing a completed request to be passed to the servlet.

The fix was to make enter() return !_complete

r2236