Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324210 - Virgo classpath contains unnecessary items
Summary: Virgo classpath contains unnecessary items
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: unknown (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.1.0.M05-incubation   Edit
Assignee: Glyn Normington CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 11:05 EDT by Borislav Kapukaranov CLA
Modified: 2010-10-05 03:58 EDT (History)
2 users (show)

See Also:


Attachments
GIT patch for the cleaned up classpath - fixed in both .bat and .sh classpath scripts (1.85 KB, patch)
2010-09-01 11:08 EDT, Borislav Kapukaranov CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Borislav Kapukaranov CLA 2010-09-01 11:05:34 EDT
Build Identifier: 2.1.0.M03-incubation

Currently Virgo's classpath contains all items in /lib folder. Most of them are unnecessary and unused. I removed them and left only 4:
org.eclipse.osgi
org.eclipse.virgo.osgi.extensions.equinox
org.eclipse.virgo.osgi.launcher
org.eclipse.virgo.kernel.authentication

With classpath that contains only these 4 items all virgo tests pass and virgo operates normally.
I'm not quite sure if the org.eclipse.virgo.kernel.authenticationitem is needed - the tests pass without it, but since it is included in virgo's bootdelegation i figured it is used somehow so i included it in the cleaned up classpath just in case.



Reproducible: Always
Comment 1 Borislav Kapukaranov CLA 2010-09-01 11:08:53 EDT
Created attachment 177966 [details]
GIT patch for the cleaned up classpath - fixed in both .bat and .sh classpath scripts
Comment 2 Glyn Normington CLA 2010-09-08 07:37:58 EDT
Thanks for this contribution. I am actually implementing a more robust solution which does not require a list to be coded in the classpath scripts.

Essentially I am reducing the set of JARs which were in lib to be just those needed on the classpath and then I'm moving those JARs into a lib/launcher directory. The classpath can then be all the JARs in lib/launcher.

This will also have the nice side-effect of reducing the disk footprint of the installation since quite a few JARs were unnecessarily duplicated in lib.

Note: shutdown JAR is needed in addition to those in your experiment so that the shutdown scripts work correctly.
Comment 3 Glyn Normington CLA 2010-09-08 09:28:42 EDT
Change committed and rippled. This will appear in milestone 5. If you want to take this for a spin before then, please build the kernel or the web server.
Comment 4 Steve Powell CLA 2010-09-17 06:59:50 EDT
This has survived usage since then (and full ci-builds) and can be closed.
Comment 5 Glyn Normington CLA 2010-09-27 08:34:28 EDT
RC1 is planned instead of milestone 5.