Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324198 - pde.junit.runtime.addon feature mal-formed
Summary: pde.junit.runtime.addon feature mal-formed
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7 M2   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 10:19 EDT by Jeff McAffer CLA
Modified: 2010-09-02 13:46 EDT (History)
2 users (show)

See Also:

Attachments
Fixed feature file (790 bytes, text/xml)
2010-09-01 10:19 EDT, Jeff McAffer CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff McAffer CLA 2010-09-01 10:19:42 EDT 
Created attachment 177957 [details]
Fixed feature file

in the Helios repo there is a feature call org.eclipse.pde.junit.runtime.addon in the Target Platform category.  This is something that came from the Jetty guys but is being adopted by the platform team.  In any event, the feature as it is in the repo is malformed.  The <requires> element needs to have <import> sub-elements rather than directly identifying the feature/plugin to require. A "fixed" version of the feature is attached to this bug.

Ideally this would be put into the maintenance release as without this fix it is hard/impossible for people to use the feature as it does not parse. The change/fix is very safe, especially since it clearly did not work before so people could not be using it :-/
Comment 1 Jeff McAffer CLA 2010-09-01 10:21:11 EDT 
I put this sin the PDE bucket but in practice, this feature was contributed by the Jetty team and it may be best for them to do the fix and contribute it to Helios SR1 as, I believe, the feature is not yet in PDE's releng build setup.  That is being done for Indigo.
Comment 2 Hugues Malphettes CLA 2010-09-01 11:42:06 EDT 
Thanks Jeff!
Sorry about this.
Fixed with commit 2232 for Helios-SR1
Comment 3 Kim Moir CLA 2010-09-02 10:08:35 EDT 
Also, the junit line should specify 4.8.1.qualifier since we have multiple junit bundles in our build.
Comment 4 Hugues Malphettes CLA 2010-09-02 11:33:29 EDT 
Kim, currently the line in the jetty repo is:
<plugin id="org.junit" download-size="0" install-size="0" version="4.8.1" unpack="true"/>

In the jetty build the qualifier is something like v20100831
It is not going to match the qualifier of the org.junit bundle in the eclipse-platform repository.

I am assuming you are suggesting this improvement for the features that lives in the indigo repository of the eclipse-platform?
Comment 5 Kim Moir CLA 2010-09-02 11:52:25 EDT 
The "qualifier" is replaced by the actual qualifier of the org.junit 4.8.1 bundle included in the platform build at build time :-)

These new pde.junit* features are now included in our 3.7 build so we are consuming the same bundles that are in our build.
Comment 6 Hugues Malphettes CLA 2010-09-02 12:03:22 EDT 
(In reply to comment #5)
> The "qualifier" is replaced by the actual qualifier of the org.junit 4.8.1
> bundle included in the platform build at build time :-)
> 
> These new pde.junit* features are now included in our 3.7 build so we are
> consuming the same bundles that are in our build.

Makes sense! So I am leaving it as is in the helios build of jetty.
Comment 7 Kim Moir CLA 2010-09-02 13:46:51 EDT 
I think this bug can be closed.  These features are now enabled in the build.  See bug 323062 for details.