Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324195 - [sequence diagrams] Default naming of elements should be improved
Summary: [sequence diagrams] Default naming of elements should be improved
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: SR1   Edit
Assignee: Mathieu Velten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 09:48 EDT by alanusse Mising name CLA
Modified: 2010-09-08 05:25 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description alanusse Mising name CLA 2010-09-01 09:48:24 EDT
Default naming of elements should be improved.

1. some elements are created without default names
-------------------------------------------------------------
For instance interaction operand

2. some elements are created with the same default name
--------------------------------------------------------------------
For instance, all combined fragments are created with the name "CombinedFragment"

3. some elements have default names with a strange naming rule
---------------------------------------------------------------------------
Some elements have their name generated automatically with a suffix but when creating more then 10 elements of the same type the naming convention is strange.

For instance we can have :
+ ActionExecSpec1 .. ActionExecSpec 10
then 
ActionExecSpec10Finish1
..
ActionExecSpec10Finish1Finish1Start  

+ This is true also for Messages

+ For Lifelines it is different but strange also
Lifeline1 to Lifeline10 is OK but after that we get
Lifeline101 , Lifeline1011, Lifeline10111
Comment 1 Thibault Landré CLA 2010-09-06 11:55:41 EDT
Fixed by a patch of Mathieu
Comment 2 alanusse Mising name CLA 2010-09-08 04:03:34 EDT
Sorry, but in my environment the pb is not fixed and I get a bug.

Environment : Helios MDT + Papyrus nightly build debug branch ==> 201009071230

When I try to created a Combined fragment

1. The combined fragment has no mane neither the operand.

2. I get a bug "Element initialization failed"

eclipse.buildId=I20100608-0911
java.version=1.6.0_03
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=fr_FR
Framework arguments:  -product org.eclipse.epp.package.modeling.product
Command-line arguments:  -os win32 -ws win32 -arch x86 -product org.eclipse.epp.package.modeling.product


Error
Wed Sep 08 09:49:27 CEST 2010
Element initialization failed

java.lang.NullPointerException
at org.eclipse.papyrus.diagram.sequence.providers.ElementInitializers.getNamedElement(ElementInitializers.java:427)
at org.eclipse.papyrus.diagram.sequence.providers.ElementInitializers.name_CombinedFragment_3004(ElementInitializers.java:260)
at org.eclipse.papyrus.diagram.sequence.providers.ElementInitializers.init_CombinedFragment_3004(ElementInitializers.java:76)
at org.eclipse.papyrus.diagram.sequence.edit.commands.CombinedFragmentCreateCommand.doExecuteWithResult(CombinedFragmentCreateCommand.java:113)
at org.eclipse.gmf.runtime.emf.commands.core.command.AbstractTransactionalCommand.doExecute(AbstractTransactionalCommand.java:247)
at org.eclipse.emf.workspace.AbstractEMFOperation.execute(AbstractEMFOperation.java:150)
at org.eclipse.gmf.runtime.diagram.ui.commands.SemanticCreateCommand.doExecuteWithResult(SemanticCreateCommand.java:91)
at org.eclipse.gmf.runtime.common.core.command.AbstractCommand.execute(AbstractCommand.java:135)
at org.eclipse.gmf.runtime.common.core.command.CompositeCommand.doExecuteWithResult(CompositeCommand.java:403)
at org.eclipse.gmf.runtime.common.core.command.AbstractCommand.execute(AbstractCommand.java:135)
at org.eclipse.gmf.runtime.diagram.ui.commands.ICommandProxy.execute(ICommandProxy.java:68)
at org.eclipse.gef.commands.CompoundCommand.execute(CompoundCommand.java:111)
at org.eclipse.gmf.runtime.diagram.ui.editpolicies.CreationEditPolicy$1.doExecuteWithResult(CreationEditPolicy.java:440)
at org.eclipse.gmf.runtime.common.core.command.AbstractCommand.execute(AbstractCommand.java:135)
at org.eclipse.core.commands.operations.DefaultOperationHistory.execute(DefaultOperationHistory.java:511)
at org.eclipse.gmf.runtime.diagram.ui.parts.DiagramCommandStack.execute(DiagramCommandStack.java:206)
at org.eclipse.gmf.runtime.diagram.ui.parts.DiagramCommandStack.execute(DiagramCommandStack.java:169)
at org.eclipse.gmf.runtime.diagram.ui.parts.DiagramCommandStack.execute(DiagramCommandStack.java:156)
at org.eclipse.gef.tools.AbstractTool.executeCommand(AbstractTool.java:426)
at org.eclipse.gef.tools.AbstractTool.executeCurrentCommand(AbstractTool.java:443)
at org.eclipse.papyrus.diagram.common.service.AspectUnspecifiedTypeCreationTool.performCreation(AspectUnspecifiedTypeCreationTool.java:112)
at org.eclipse.gef.tools.CreationTool.handleButtonUp(CreationTool.java:186)
at org.eclipse.gef.tools.AbstractTool.mouseUp(AbstractTool.java:1206)
at org.eclipse.gef.EditDomain.mouseUp(EditDomain.java:301)
at org.eclipse.gef.ui.parts.DomainEventDispatcher.dispatchMouseReleased(DomainEventDispatcher.java:380)
at org.eclipse.draw2d.LightweightSystem$EventHandler.mouseUp(LightweightSystem.java:548)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:213)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
Comment 3 Mathieu Velten CLA 2010-09-08 05:25:05 EDT
fixed locally.