Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324192 - Cannot open a renamed file
Summary: Cannot open a renamed file
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2.2   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-01 09:38 EDT by Samuel Wu CLA
Modified: 2010-11-09 08:16 EST (History)
2 users (show)

See Also:
mober.at+eclipse: pmc_approved+
kjdoyle: review+

Attachments
patch to update the editable on rename even if it's not open (2.05 KB, patch)
2010-09-01 10:02 EDT, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Wu CLA 2010-09-01 09:38:25 EDT 
Build Identifier: org.eclipse.rse.core_3.2.1.v201008191400-7a7FFMVFC7sRd_S_c_dcsY

This is a regression problem we didn't see with RSE 3.0.x


Reproducible: Always

Steps to Reproduce:
1) Double click on a local file D:\temp\test.txt to open it in the editor.
2) Close the file.
3) Hit F2 and rename the file to D:\temp\test1.txt.
4) Double click on the renamed file.
RSEF1002
Operation failed. File system input or output error
Message reported from file system: D:\temp\test.txt (The system cannot find the file specified.)

When the above steps were tried on linux host, the file open action kept running and never ended.
Comment 1 David McKnight CLA 2010-09-01 10:02:45 EDT 
Created attachment 177954 [details]
patch to update the editable on rename even if it's not open
Comment 2 David McKnight CLA 2010-09-01 10:03:49 EDT 
We don't hit the problem if the editor isn't closed but, in the case where the editor is closed, we aren't updating the corresponding SystemEditableRemoteFile during the rename operation.  Can you try with this patch?
Comment 3 Samuel Wu CLA 2010-09-01 10:56:27 EDT 
Thank you, Dave, for the prompt response. The patch fixed the problem.
Comment 4 David McKnight CLA 2010-09-01 11:01:38 EDT 
Kevin, could you review this one?  Thanks.
Comment 5 Kevin Doyle CLA 2010-09-01 11:52:14 EDT 
Review +.
Comment 6 David McKnight CLA 2010-09-01 12:12:28 EDT 
Thanks for the review.  I've committed the change to cvs.
Comment 7 Martin Oberhuber CLA 2010-09-08 04:21:29 EDT 
Released for 3.2.1rc4.
Comment 8 Martin Oberhuber CLA 2010-11-09 08:16:06 EST 
Verified that this has been released to 3.3m3 as well.