This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 324148 - User should be warned if none of the artifact rules match the artifacts during generation
Summary: User should be warned if none of the artifact rules match the artifacts durin...
Status: VERIFIED FIXED
Alias: None
Product: Tigerstripe (Archived)
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.5M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 18:14 EDT by Navid Mehregani CLA
Modified: 2010-12-21 13:18 EST (History)
1 user (show)

See Also:


Attachments
Patch_1 (7.62 KB, text/plain)
2010-12-16 10:15 EST, Valentin Yerastov CLA
no flags Details
Patch_2 (2.81 KB, text/plain)
2010-12-21 11:15 EST, Valentin Yerastov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Navid Mehregani CLA 2010-08-31 18:14:22 EDT
Build Identifier: 

If none of the rules for a Tigerstripe project match the artifacts of a model project, the generation completes and user is presented with a message indicating that the generation was successful.  However, no code is generated as expected.  In this scenario, user should be warned when none of the rules of a plugin match the artifacts of a TS Project.

Reproducible: Always

Steps to Reproduce:
1. Create a model project with only a Session Facade artifact
2. Create a TS plugin with a rule that only applies to an Entity artifact
3. Generate code for your model project using the created plugin.  Notice that a message pops up indicating that generation was successful.  However, no code was generated since the rules didn't match any of the artifacts in the project.
Comment 1 Navid Mehregani CLA 2010-12-10 10:17:49 EST
This is also problematic when you try to use a generator, which has no rules.  It pops up a dialog indicating that generation was successful with no indication that the generator doesn't contain any rules
Comment 2 Valentin Yerastov CLA 2010-12-16 10:15:07 EST
Created attachment 185329 [details]
Patch_1

Fixed.
Comment 3 Yuri Strot CLA 2010-12-17 08:32:30 EST
Valentin's patch applied.
Comment 4 Navid Mehregani CLA 2010-12-21 09:49:49 EST
The heading in the generation dialog still says "Generation Successful".  I was expecting this to be changed to a yellow colour warning.  Similar to how other warnings are done.

The generation text indicates none of the rules changed, but please also change the heading.
Comment 5 Valentin Yerastov CLA 2010-12-21 11:15:43 EST
Created attachment 185650 [details]
Patch_2

Fixed
Comment 6 Yuri Strot CLA 2010-12-21 11:22:56 EST
Applied second patch as well.
Comment 7 Navid Mehregani CLA 2010-12-21 13:18:25 EST
Looks good.  Thanks!