Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324076 - Removing @noextend and adding @nooverride results API tool problem being reported
Summary: Removing @noextend and adding @nooverride results API tool problem being repo...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 07:19 EDT by Dani Megert CLA
Modified: 2010-10-11 10:24 EDT (History)
4 users (show)

See Also:
Michael_Rennie: review+
Michael_Rennie: review? (darin.eclipse)

Attachments
Proposed fix + regression test (95.43 KB, patch)
2010-09-09 13:48 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-08-31 07:19:02 EDT 
3.6.

Removing @noextend on a class and adding @nooverride on its methods results API tool error being reported.
Comment 1 Dani Megert CLA 2010-08-31 08:30:49 EDT 
>3.6.
N20100829-2000 but probably also in 3.6.

For steps see bug 324079 comment 0.
Comment 2 Darin Wright CLA 2010-08-31 10:56:08 EDT 
I see... Since the class was @noextend, you were not previously allowed to override the method... so the @nooverride restriction should not be considered as new.
Comment 3 Olivier Thomann CLA 2010-09-09 13:48:12 EDT 
Created attachment 178540 [details]
Proposed fix + regression test
Comment 4 Olivier Thomann CLA 2010-09-09 13:48:27 EDT 
Darin, Michael, please review.
Comment 5 Michael Rennie CLA 2010-09-27 11:31:52 EDT 
+1 works for me and all tests pass. Adding Darin as a reviewer like Olivier intended.
Comment 6 Olivier Thomann CLA 2010-10-06 14:11:06 EDT 
Released for 3.7M3.
Comment 7 Dani Megert CLA 2010-10-11 10:24:27 EDT 
Verified in N20101010-2000.