Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324072 - Debug view "Terminate/Disconnect All" doesn't work
Summary: Debug view "Terminate/Disconnect All" doesn't work
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6.1   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-31 06:44 EDT by Michael Dillon CLA
Modified: 2010-09-03 12:16 EDT (History)
4 users (show)

See Also:
daniel_megert: pmc_approved+
curtis.windatt.public: review+

Attachments
patch for 3.7 (1.12 KB, patch)
2010-08-31 10:29 EDT, Darin Wright CLA 		no flags Details | Diff
patch for 3.6.1 (1.27 KB, patch)
2010-09-01 09:35 EDT, Darin Wright CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Dillon CLA 2010-08-31 06:44:09 EDT 
Build Identifier: 20100617-1415

Right-clicking a process in the debug view, and select "Terminate/Disconnect All" only terminates the selected process.

Reproducible: Always

Steps to Reproduce:
1. Start muliple jvms. I was using jdk 1.6.
2. Right-click one of the running apps in the Debug view.
3. From the popup-menu select "Terminate/Disconnect All".
Comment 1 Darin Wright CLA 2010-08-31 10:29:41 EDT 
Created attachment 177843 [details]
patch for 3.7

This bug was introduced when DebugCommandAction was made API in 3.6. The method #getContext() was made private, and the TerminateAllAction was no longer able to override the method. The fix is to make the API method protected and allow subclasses to override.
Comment 2 Darin Wright CLA 2010-08-31 10:44:42 EDT 
This is a regression in 3.6, since 3.5. As the fix requires an API addition (to new API that was added in 3.6), I am not sure if this should go into 3.6.1. The workaround is to "select all & terminate". Dani, do you have an opinion on inclusion in 3.6.1?
Comment 3 Darin Wright CLA 2010-08-31 13:05:45 EDT 
This will at least be a 3.7 candidate.
Comment 4 Dani Megert CLA 2010-09-01 03:16:26 EDT 
The regression causes confusion and should get fixed for 3.6.1. The fix is simple and works.

>As the fix requires an API addition
In order to not touch API we can mark 'getContext' with @nooverride and @noreference in 3.6.1.
Comment 5 Darin Wright CLA 2010-09-01 09:35:26 EDT 
Created attachment 177952 [details]
patch for 3.6.1
Comment 6 Darin Wright CLA 2010-09-01 09:38:54 EDT 
Released to 3.6.1
Comment 7 Darin Wright CLA 2010-09-01 09:43:32 EDT 
Released to 3.7
Comment 8 Darin Wright CLA 2010-09-02 09:28:57 EDT 
Verified in M20100901-1310
Comment 9 Curtis Windatt CLA 2010-09-03 12:16:35 EDT 
Verified with M20100902-1717