Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324034 - User should be warned if there are no deployed plugins (generators)
Summary: User should be warned if there are no deployed plugins (generators)
Status: RESOLVED FIXED
Alias: None
Product: Tigerstripe
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P5 trivial (vote)
Target Milestone: 0.5M0   Edit
Assignee: Daniel Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-30 17:16 EDT by Navid Mehregani CLA
Modified: 2010-09-14 14:57 EDT (History)
1 user (show)

See Also:


Attachments
Project Descriptor (18.88 KB, image/png)
2010-08-30 17:18 EDT, Navid Mehregani CLA
no flags Details
patch_324034 (2.16 KB, patch)
2010-09-03 14:35 EDT, Daniel Johnson CLA
no flags Details | Diff
patch_324034.txt (7.49 KB, patch)
2010-09-14 14:08 EDT, Daniel Johnson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Navid Mehregani CLA 2010-08-30 17:16:54 EDT
Build Identifier: 

Under 'Plugin Settings' page of a project descriptor (tigerstripe.xml file), user should be warned if there are no deployed plugins.  There should be a blurb indicating that "There are no deployed plug-ins and nothing can be generated for this model unless a plugin is deployed.  To create a new Tigerstripe Plugin Project, click on File > New > Tigerstripe Plugin Project."

It would even be better if user was provided a link to create a new plugin project.  Clicking on the link would start the new plugin project wizard.

Reproducible: Always
Comment 1 Navid Mehregani CLA 2010-08-30 17:18:34 EDT
Created attachment 177789 [details]
Project Descriptor 

Right now, this is what the user sees if there are no deployed plugins.  This is really confusing...I would even take out "Click here to change the generation settings for this project." if there are no deployed plugins.  There is no point of changing generating settings when there are no plugins to generate code from.
Comment 2 Navid Mehregani CLA 2010-08-30 17:19:32 EDT
Dan, can you please take a look whenever you get a chance? Thanks!
Comment 3 Daniel Johnson CLA 2010-08-30 17:54:08 EDT
Why do you think it is a bad idea for them to be able to change the settings without any deployed plug-ins? I would say putting a link to create a new project if they don't have one is a good idea, but looking at the settings they don't seem to be specific to any specific plug-in. Maybe I just don't understand the interworkings enough to know if it creates a problem though.
Any idea how I might go about figuring out if there are any deployed plug-ins?
Comment 4 Navid Mehregani CLA 2010-08-30 18:05:26 EDT
(In reply to comment #3)
> Why do you think it is a bad idea for them to be able to change the settings
> without any deployed plug-ins?

It's not a bad idea.  I just don't think anyone would do this before creating and deploying a plugin.  That message really confused me when I saw it for the first time.  I didn't have any deployed plugins and naturally (since it's the only thing appearing on the page) I clicked on the link.  I'm OK with leaving this message in there, as long as the blurb warning the user about not having any deployed plugins appears before it.

> Any idea how I might go about figuring out if there are any deployed plug-ins?

Look at the implementation for the 'Deployed Generators...' action listed under Tigerstripe menu:

PluginManager mgr = PluginManager.getManager();
List<PluggableHousing> pluggableHousings = mgr.getRegisteredPluggableHousings();
Comment 5 Richard Craddock CLA 2010-08-31 04:33:05 EDT
This is a VERY rare case...

I think we have mor eimportantissues to fix than this.
Comment 6 Navid Mehregani CLA 2010-08-31 09:17:04 EDT
(In reply to comment #5)
> This is a VERY rare case...
> 
> I think we have mor eimportantissues to fix than this.

All new users following the Tigerstripe tutorial posted on the Wiki will run into this problem.  I ran into it myself as well.  
I'm in the process of updating/modifying the tutorials right now, but I don't think this is such a rare case for a new Tigerstripe users!
Comment 7 Daniel Johnson CLA 2010-09-03 14:35:44 EDT
Created attachment 178188 [details]
patch_324034

Can not figure out how to launch the wizard from a link easily. But at least informs the user of what they should do.
Changed GenerationPrefSection.java
Comment 8 Navid Mehregani CLA 2010-09-14 13:44:22 EDT
Patch reviewed and submitted.  Thanks!
Comment 9 Daniel Johnson CLA 2010-09-14 14:08:22 EDT
Created attachment 178859 [details]
patch_324034.txt

Hey sorry Navid, last week I found a way to launch the new project wizard through a link, but was on the caltrain and couldn't submit it. I meant to do this yesterday but forgot. Here is the revised patch.

Class changed: GenerationPrefSection.java
Comment 10 Navid Mehregani CLA 2010-09-14 14:57:38 EDT
Sweet! :-) I've applied the updated patch.  

Saw your comment about searching for the wizard id as opposed to hard-coding it.  I don't think it's necessary (or worth it) so no need to worry about it.