Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324010 - edc - Registers.java writing empty "OK" messages to Error Log
Summary: edc - Registers.java writing empty "OK" messages to Error Log
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 7.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-30 14:32 EDT by Kirk Beitz CLA
Modified: 2012-05-22 14:51 EDT (History)
2 users (show)

See Also:

Attachments
patch to check if status is "OK" before logging to error log (945 bytes, patch)
2010-08-30 14:32 EDT, Kirk Beitz CLA 		no flags Details | Diff
patch to check rm.isSuccess() prior to attempting to log result (832 bytes, patch)
2010-08-30 16:49 EDT, Kirk Beitz CLA 		cdtdoug: iplog+
kirk.beitz: review?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirk Beitz CLA 2010-08-30 14:32:29 EDT 
Created attachment 177762 [details]
patch to check if status is "OK" before logging to error log

when operating the edc debugger, it regularly writes empty "OK" messages to the Error Log view, cluttering it unnecessarily.

i tracked this to Registers.java ... see the attached patch for the suggested fix.

Ling, i've CC:ed you because you are the last one to submit changes to this file.  can you take this and review it and commit it to help ken from having to do so much of my commit work?
Comment 1 Ling Wang CLA 2010-08-30 15:55:03 EDT 
Kirk, it may be better to just use "if (! rm.isSuccess())" as the check condition.
Comment 2 Kirk Beitz CLA 2010-08-30 16:49:54 EDT 
Created attachment 177786 [details]
patch to check rm.isSuccess() prior to attempting to log result

(In reply to comment #1)
> Kirk, it may be better to just use "if (! rm.isSuccess())" as the check
> condition.

ok, Ling, the updated patch now reflects this.
Comment 3 Ling Wang CLA 2010-08-30 17:43:07 EDT 
Committed the patch to head.
Comment 4 CDT Genie CLA 2010-08-30 18:23:02 EDT 
*** cdt cvs genie on behalf of lwang ***
Bug 324010: edc - Registers.java writing empty "OK" messages to Error Log

[*] Registers.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/services/Registers.java?root=Tools_Project&r1=1.10&r2=1.11