Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323991 - [Class Diagram] Bug with Affixed Child Node ContainmentCircleEditPart
Summary: [Class Diagram] Bug with Affixed Child Node ContainmentCircleEditPart
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Patrick Tessier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 323957 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-30 12:00 EDT by Vincent Lorenzo CLA
Modified: 2010-11-04 11:02 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2010-08-30 12:00:31 EDT
In the GMFGen, the semantic element for the Affixed Node ContainmentCircleEditPart is the UML Port.
This choice is a problem when we want show a UML Port with the Show/Hide Contents Action. In this case, the Port is not represented like a Property in a Compartment,  but like an Affixed Child Node, with the ContainmentCircle Figure.

Step to reproduce : 
1/Create a Composite Diagram
2/Create a Class on this diagram
3/Create a Port on this Class
4/Create a Class Diagram
5/Drop the class in the Class Diagram
6/Use the Show Contents Action to see the Port in this class.
Comment 1 Vincent Lorenzo CLA 2010-08-30 12:01:25 EDT
*** Bug 323957 has been marked as a duplicate of this bug. ***
Comment 2 Patrick Tessier CLA 2010-10-28 08:09:05 EDT
done in the revision 3043
To do that I have remove the modelfacet from the gmfgen ContainmentCircleEditPart
I have replaced MetamodelType element  by a NotationType element. I have also written the same identifier

To allow the generation, I have also fixe a bug in the template of VisualIDRegistry

The original code do not pay attention if a element facet exist to edit generate the constraint. So at each generation, a mistake was raised.
In order to solve it, I test if the node is associated to a sematic element by using the attribute  sansDomain of the meta attribute  in the gmfgen. 

«IF null <> editorGen.expressionProviders-»
	«EXPAND _constraintMethod FOREACH topLevelNodes->select(n | n.modelFacet.modelElementSelector <> null and n.sansDomain = false)-»
	«EXPAND _constraintMethod FOREACH childNodes->select(n | n.modelFacet.modelElementSelector <> null and n.sansDomain = false)-»
	«FOREACH links AS l»«EXPAND _constraintMethod(l) FOR l.modelFacet»«ENDFOREACH»
«ENDIF-»
Comment 3 Yann Tanguy CLA 2010-11-04 11:02:59 EDT
In r3116 : Incorrect naming of ContainmentCircle id ("ContainementCircle" instead of "ContainmentCircle") provoked errors in RequirementDiagram.