Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323973 - JSP translation lacks package fragment root
Summary: JSP translation lacks package fragment root
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-30 10:38 EDT by Nick Sandonato CLA
Modified: 2010-12-14 15:22 EST (History)
4 users (show)

See Also:
thatnitind: review+

Attachments
patch (2.47 KB, patch)
2010-08-30 10:38 EDT, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-08-30 10:38:19 EDT 
Created attachment 177733 [details]
patch

When creating the compilation unit for a JSP translation, it's missing a package fragment root. While most functionality is still present, refactoring tends to not work due to the JDT requiring a package fragment root for the compilation unit, otherwise it thinks the source file is outside of the classpath and so the JDT Match locator skips over it.
Comment 1 Nick Sandonato CLA 2010-08-30 10:40:12 EDT 
To be clear, this is a regression, where before the source was part of a package fragment root, and currently it is not. This attached patch will add the compilation unit back to a package fragment root.
Comment 2 Nitin Dahyabhai CLA 2010-08-31 14:44:01 EDT 
This seems dependent on there being a Source folder on the build path.  Do things work if there is not one?
Comment 3 Nick Sandonato CLA 2010-08-31 20:10:54 EDT 
(In reply to comment #2)
> This seems dependent on there being a Source folder on the build path.  Do
> things work if there is not one?

We've always been dependent on there being a Source folder in the build path. There may be a way for us to remove this dependency, but as noted, without a package fragment root, JDT will not allow us to refactor anyway.
Comment 4 Nick Sandonato CLA 2010-12-14 15:22:56 EST 
Code checked in. Thanks, Nitin.