Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323953 - External Tools Launch delegate no longer supports launch in background
Summary: External Tools Launch delegate no longer supports launch in background
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 3.6.1   Edit
Assignee: Platform-Ant-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 321096 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-30 07:07 EDT by James Blackburn CLA
Modified: 2010-09-02 09:26 EDT (History)
5 users (show)

See Also:
daniel_megert: pmc_approved+
Michael_Rennie: review+

Attachments
patch 1 (1.77 KB, patch)
2010-08-30 07:07 EDT, James Blackburn CLA 		no flags Details | Diff
patch for 3.7 (2.94 KB, patch)
2010-08-30 16:29 EDT, Darin Wright CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Blackburn CLA 2010-08-30 07:07:56 EDT 
Created attachment 177718 [details]
patch 1

The external tools launch delegate: ProgramLaunchDelegate#launch spins waiting until the underlying program has exited.
This is different to other launch delegates, which are expected to return immediately having launched the launch configuration.

As a result calls to ILaunchConfiguration#lanch doesn't return in a timely manner, only returning when the launch has been completed.

Simple patch attached.
Comment 1 Michael Rennie CLA 2010-08-30 10:44:58 EDT 
Thanks for the patch James, I am curious though why that code was ever commented out. 

Prior to the fix for bug 264338 there was an if-then that used to honour the launch-in-background settings, and one of the patches commented it all out. Maybe Darin W can shed some light on what he was thinking at the time.
Comment 2 Darin Wright CLA 2010-08-30 11:33:28 EDT 
Looks like this just fell through the cracks during the 3.6 refactoring to make external tool launching headless. It should be fixed, and is a regrression.
Comment 3 Darin Wright CLA 2010-08-30 11:42:12 EDT 
Marking as 3.6.1 candidate.
Comment 4 Darin Wright CLA 2010-08-30 16:29:15 EDT 
Created attachment 177782 [details]
patch for 3.7
Comment 5 Darin Wright CLA 2010-08-30 16:29:44 EDT 
*** Bug 321096 has been marked as a duplicate of this bug. ***
Comment 6 Darin Wright CLA 2010-08-30 16:31:41 EDT 
Released to 3.7 (HEAD).
Comment 7 Darin Wright CLA 2010-08-30 16:38:20 EDT 
Adding Dani for 3.6.1 PMC approval in RC3. (note, patch works for both 3.7 and
3.6.1). Adding Michael for review.
Comment 8 Dani Megert CLA 2010-08-31 06:05:35 EDT 
(In reply to comment #2)
> Looks like this just fell through the cracks during the 3.6 refactoring to make
> external tool launching headless. It should be fixed, and is a regrression.
Agree.

Verified the fix and the behavior. +1 for 3.6.1 RC3.

Don't forget to update the bundle version to 1.0.1.
Comment 9 Darin Wright CLA 2010-08-31 09:48:42 EDT 
Released to 3.6.1. Updated bundle version to 1.0.1.
Comment 10 Michael Rennie CLA 2010-08-31 10:28:29 EDT 
+1 verified
Comment 11 Darin Wright CLA 2010-09-02 09:26:14 EDT 
Verified in M20100901-1310