Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323942 - [Net] Unnecessary native method call
Summary: [Net] Unnecessary native method call
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-30 05:40 EDT by Wojciech Galanciak CLA
Modified: 2010-09-20 04:05 EDT (History)
2 users (show)

See Also:
Szymon.Brandys: review+

Attachments
fix (913 bytes, text/plain)
2010-08-30 05:40 EDT, Wojciech Galanciak CLA 		no flags Details
fix (913 bytes, patch)
2010-08-30 05:43 EDT, Wojciech Galanciak CLA 		Szymon.Brandys: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wojciech Galanciak CLA 2010-08-30 05:40:29 EDT 
Created attachment 177708 [details]
fix

In ProxyManager there is an unnecessary call to select method from native provider (see attached fix). We cannot assume that two calls (one after another) will both return non-empty array so it still can throw AIOOBE. Additionally, it is less efficiently.
Comment 1 Wojciech Galanciak CLA 2010-08-30 05:43:21 EDT 
Created attachment 177709 [details]
fix
Comment 2 Pawel Pogorzelski CLA 2010-09-07 06:40:26 EDT 
Good catch Wojciech, the fix is good.
Comment 3 Szymon Brandys CLA 2010-09-20 04:00:17 EDT 
Checked in to HEAD.