Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323928 - Rename branch is available without selection
Summary: Rename branch is available without selection
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0-M3   Edit
Assignee: Mathias Kinzler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-30 00:07 EDT by Marc-André Laperle CLA
Modified: 2010-08-30 16:26 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2010-08-30 00:07:12 EDT 
Using EGit from HEAD (should be hudson build #482)

1. Go to the Git repositories view for the first time since Eclipse has been started (nothing selected)
2. With still nothing selected, right click in the background, Rename Branch is available. Using it triggers an Exception:

java.lang.ArrayIndexOutOfBoundsException: 0
	at java.util.Arrays$ArrayList.get(Unknown Source)
	at org.eclipse.egit.ui.internal.repository.tree.command.RenameBranchCommand.execute(RenameBranchCommand.java:40)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
	at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
	at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
	at org.eclipse.ui.menus.CommandContributionItem.handleWidgetSelection(CommandContributionItem.java:820)
	at org.eclipse.ui.menus.CommandContributionItem.access$19(CommandContributionItem.java:806)
Comment 1 Mathias Kinzler CLA 2010-08-30 04:24:39 EDT 
Code review at http://egit.eclipse.org/r/#change,1451
Comment 2 Chris Aniszczyk CLA 2010-08-30 16:26:25 EDT 
Fixed with 7dc9adec8bd867893212d7abb5118429433847c0.

Thanks Mathias.