Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323896 - add missing property values
Summary: add missing property values
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.css (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 minor (vote)
Target Milestone: 3.2.3   Edit
Assignee: Rakesh CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-28 20:19 EDT by jzaruba CLA
Modified: 2010-10-27 13:11 EDT (History)
2 users (show)

See Also:
nsand.dev: review+

Attachments
patch (81.52 KB, patch)
2010-09-08 08:07 EDT, Rakesh CLA 		no flags Details | Diff
new patch (7.05 KB, patch)
2010-10-27 00:18 EDT, Rakesh CLA 		nsand.dev: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jzaruba CLA 2010-08-28 20:19:56 EDT 
Build Identifier: 

The editor is missing some property values, it does not offer them while auto-completing.
For 'display' property the editor should also offer 'inline-block' (CSS2), for all properties 'initial' (CSS3) is also valid value.

Reproducible: Always
Comment 1 jzaruba CLA 2010-08-28 20:29:13 EDT 
other missing properties:
 - 'box-shadow'
http://www.w3.org/TR/css3-background/#the-box-shadow

 - 'border-radius'
 - 'border-top-left-radius'
 - 'border-top-right-radius'
 - 'border-bottom-right-radius'
 - 'border-bottom-left-radius'
http://www.w3.org/TR/css3-background/#border-radius

 - 'rgba()' for color values
http://www.w3.org/TR/css3-color/#rgba-color
Comment 2 Rakesh CLA 2010-09-08 08:07:39 EDT 
Created attachment 178390 [details]
patch

We don't support CSS3 right now.Some of the property values you mentioned for example 'inline-block' were added in CSS2.1.
Source:
http://www.w3.org/TR/CSS2/changes.html#q3
Based on changes for 2.1, i am attaching a patch.Request for CSS3 in my opinion is an enhancement.
Comment 3 jzaruba CLA 2010-09-08 08:24:36 EDT 
(In reply to comment #2)
> Request for CSS3 in my opinion is an enhancement.

I have filed a new request: https://bugs.eclipse.org/bugs/show_bug.cgi?id=324731
Comment 4 Nick Sandonato CLA 2010-10-26 16:55:51 EDT 
Hi Rakesh,

I would prefer if we just included the changes for 2.1 into the profile for 2. I do not think revision 1 was large enough to justify an entirely new profile. Also, I'm not fully certain that these profiles hold much weight these days. Finally, by not creating a new profile, we can merge these changes in time for 3.2.3.

Thanks for taking a look.
Comment 5 Rakesh CLA 2010-10-27 00:18:58 EDT 
Created attachment 181796 [details]
new patch

New patch based on above suggestion.
Comment 6 Nick Sandonato CLA 2010-10-27 13:10:58 EDT 
Looks good. Thanks, Rakesh.