Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323884 - new Inspect action popup dialog exception, when isn't selected entire expression
Summary: new Inspect action popup dialog exception, when isn't selected entire expression
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Zhongwei Zhao CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-28 06:43 EDT by Silver Zachara CLA
Modified: 2020-05-14 11:07 EDT (History)
3 users (show)

See Also:
ganoro: review+
zhaozhongwei: review?
zhaozhongwei: review? (zhaozhongwei)

Attachments
patch (5.39 KB, patch)
2010-09-01 03:53 EDT, Zhongwei Zhao CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Silver Zachara CLA 2010-08-28 06:43:11 EDT 
Hi,

example, I want to show output of this expression by CTRL+SHIFT+I:
@strtoupper(str_replace('-', '_', $header))@ 

but when I don't select whole expression, so I select only e.g. this part ( without last parenthesis ):
@strtoupper(str_replace('-', '_', $header)@ 

This modal dialog with this error is showed:
An internal error occurred during: "Label Job".
java.lang.NullPointerException

And this exception occurs in consolelog:

!ENTRY org.eclipse.php.debug.core 4 4 2010-08-28 12:41:30.078
!MESSAGE class org.eclipse.php.internal.debug.core.xdebug.dbgp.model.DBGpTarget : DBGp Response Error: eval:=206 msg:error evaluating code

!ENTRY org.eclipse.debug.ui 4 2 2010-08-28 12:41:30.109
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.debug.ui".
!STACK 0
java.lang.NullPointerException
        at org.eclipse.php.internal.debug.ui.actions.PopupInspectAction$1.getModelIdentifier(PopupInspectAction.java:173)
        at org.eclipse.debug.internal.ui.views.variables.details.DefaultDetailPane.display(DefaultDetailPane.java:602)
        at org.eclipse.debug.internal.ui.views.variables.details.DetailPaneProxy.display(DetailPaneProxy.java:117)
        at org.eclipse.debug.ui.InspectPopupDialog$2.updateComplete(InspectPopupDialog.java:156)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider$17.run(ModelContentProvider.java:1858)
        at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.notifyUpdate(ModelContentProvider.java:1845)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateComplete(ModelContentProvider.java:1808)
        at org.eclipse.debug.internal.ui.viewers.model.ViewerUpdateMonitor$1.runInUIThread(ViewerUpdateMonitor.java:103)
        at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4041)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3660)
        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
        at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
        at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1407)

!ENTRY org.eclipse.debug.ui 4 120 2010-08-28 12:41:30.109
!MESSAGE Error logged from Debug UI:
!STACK 0
java.lang.NullPointerException
        at org.eclipse.php.internal.debug.ui.actions.PopupInspectAction$1.getModelIdentifier(PopupInspectAction.java:173)
        at org.eclipse.debug.internal.ui.views.variables.details.DefaultDetailPane.display(DefaultDetailPane.java:602)
        at org.eclipse.debug.internal.ui.views.variables.details.DetailPaneProxy.display(DetailPaneProxy.java:117)
        at org.eclipse.debug.ui.InspectPopupDialog$2.updateComplete(InspectPopupDialog.java:156)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider$17.run(ModelContentProvider.java:1858)
        at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.notifyUpdate(ModelContentProvider.java:1845)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateComplete(ModelContentProvider.java:1808)
        at org.eclipse.debug.internal.ui.viewers.model.ViewerUpdateMonitor$1.runInUIThread(ViewerUpdateMonitor.java:103)
        at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4041)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3660)
        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
        at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
        at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1407)

!ENTRY org.eclipse.core.jobs 4 2 2010-08-28 12:41:30.109
!MESSAGE An internal error occurred during: "Label Job".
!STACK 0
java.lang.NullPointerException
        at org.eclipse.php.internal.debug.ui.actions.PopupInspectAction$1.getModelIdentifier(PopupInspectAction.java:173)
        at org.eclipse.debug.internal.ui.DelegatingModelPresentation.getConfiguredPresentation(DelegatingModelPresentation.java:248)
        at org.eclipse.debug.internal.ui.DelegatingModelPresentation.getText(DelegatingModelPresentation.java:156)
        at org.eclipse.debug.internal.ui.views.launch.DebugElementHelper.getLabel(DebugElementHelper.java:93)
        at org.eclipse.debug.internal.ui.model.elements.DebugElementLabelProvider.getLabel(DebugElementLabelProvider.java:37)
        at org.eclipse.debug.internal.ui.model.elements.VariableLabelProvider.getLabel(VariableLabelProvider.java:88)
        at org.eclipse.debug.internal.ui.model.elements.ExpressionLabelProvider.getLabel(ExpressionLabelProvider.java:48)
        at org.eclipse.debug.internal.ui.model.elements.ElementLabelProvider.getLabel(ElementLabelProvider.java:312)
        at org.eclipse.debug.internal.ui.model.elements.ElementLabelProvider.retrieveLabel(ElementLabelProvider.java:215)
        at org.eclipse.debug.internal.ui.model.elements.ElementLabelProvider$LabelUpdater.run(ElementLabelProvider.java:160)
        at org.eclipse.debug.internal.ui.model.elements.ElementLabelProvider$LabelJob.run(ElementLabelProvider.java:74)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 1 Zhongwei Zhao CLA 2010-08-29 23:26:54 EDT 
fixed
Comment 2 Zhongwei Zhao CLA 2010-09-01 03:53:48 EDT 
Created attachment 177920 [details]
patch
Comment 3 Silver Zachara CLA 2010-09-03 14:39:03 EDT 
Still exists in SR1 with this excpetions in consolelog, so I reopen this:

!ENTRY org.eclipse.php.debug.core 4 4 2010-09-03 20:36:31.781
!MESSAGE class org.eclipse.php.internal.debug.core.xdebug.dbgp.model.DBGpTarget : DBGp Response Error: eval:=206 msg:error evaluating code

!ENTRY org.eclipse.debug.ui 4 2 2010-09-03 20:36:31.812
!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.debug.ui".
!STACK 0
java.lang.NullPointerException
        at org.eclipse.php.internal.debug.ui.actions.PopupInspectAction$1.getModelIdentifier(PopupInspectAction.java:158)
        at org.eclipse.debug.internal.ui.views.variables.details.DefaultDetailPane.display(DefaultDetailPane.java:602)
        at org.eclipse.debug.internal.ui.views.variables.details.DetailPaneProxy.display(DetailPaneProxy.java:117)
        at org.eclipse.debug.ui.InspectPopupDialog$2.updateComplete(InspectPopupDialog.java:156)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider$17.run(ModelContentProvider.java:1858)
        at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.notifyUpdate(ModelContentProvider.java:1845)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateComplete(ModelContentProvider.java:1808)
        at org.eclipse.debug.internal.ui.viewers.model.ViewerUpdateMonitor$1.runInUIThread(ViewerUpdateMonitor.java:103)
        at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4041)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3660)
        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
        at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
        at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1407)

!ENTRY org.eclipse.debug.ui 4 120 2010-09-03 20:36:31.812
!MESSAGE Error logged from Debug UI:
!STACK 0
java.lang.NullPointerException
        at org.eclipse.php.internal.debug.ui.actions.PopupInspectAction$1.getModelIdentifier(PopupInspectAction.java:158)
        at org.eclipse.debug.internal.ui.views.variables.details.DefaultDetailPane.display(DefaultDetailPane.java:602)
        at org.eclipse.debug.internal.ui.views.variables.details.DetailPaneProxy.display(DetailPaneProxy.java:117)
        at org.eclipse.debug.ui.InspectPopupDialog$2.updateComplete(InspectPopupDialog.java:156)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider$17.run(ModelContentProvider.java:1858)
        at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.notifyUpdate(ModelContentProvider.java:1845)
        at org.eclipse.debug.internal.ui.viewers.model.ModelContentProvider.updateComplete(ModelContentProvider.java:1808)
        at org.eclipse.debug.internal.ui.viewers.model.ViewerUpdateMonitor$1.runInUIThread(ViewerUpdateMonitor.java:103)
        at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4041)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3660)
        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
        at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
        at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1407)

!ENTRY org.eclipse.core.jobs 4 2 2010-09-03 20:36:31.812
!MESSAGE An internal error occurred during: "Label Job".
!STACK 0
java.lang.NullPointerException
        at org.eclipse.php.internal.debug.ui.actions.PopupInspectAction$1.getModelIdentifier(PopupInspectAction.java:158)
        at org.eclipse.debug.internal.ui.DelegatingModelPresentation.getConfiguredPresentation(DelegatingModelPresentation.java:248)
        at org.eclipse.debug.internal.ui.DelegatingModelPresentation.getText(DelegatingModelPresentation.java:156)
        at org.eclipse.debug.internal.ui.views.launch.DebugElementHelper.getLabel(DebugElementHelper.java:93)
        at org.eclipse.debug.internal.ui.model.elements.DebugElementLabelProvider.getLabel(DebugElementLabelProvider.java:37)
        at org.eclipse.debug.internal.ui.model.elements.VariableLabelProvider.getLabel(VariableLabelProvider.java:88)
        at org.eclipse.debug.internal.ui.model.elements.ExpressionLabelProvider.getLabel(ExpressionLabelProvider.java:48)
        at org.eclipse.debug.internal.ui.model.elements.ElementLabelProvider.getLabel(ElementLabelProvider.java:312)
        at org.eclipse.debug.internal.ui.model.elements.ElementLabelProvider.retrieveLabel(ElementLabelProvider.java:215)
        at org.eclipse.debug.internal.ui.model.elements.ElementLabelProvider$LabelUpdater.run(ElementLabelProvider.java:160)
        at org.eclipse.debug.internal.ui.model.elements.ElementLabelProvider$LabelJob.run(ElementLabelProvider.java:74)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 4 Roy Ganor CLA 2010-09-03 17:43:14 EDT 
reviewed

Thanks!
Comment 5 Q.S. Wang CLA 2010-09-05 20:49:00 EDT 
Can't apply the patch. Conflicting exists.
Comment 6 Roy Ganor CLA 2010-09-06 04:27:33 EDT 
fixed by Zhao!
Comment 7 Silver Zachara CLA 2010-09-12 17:20:02 EDT 
Hi,

is this fixed in sr1 rc3? Because I can reproduce this bug in this release:
http://build.eclipse.org/technology/epp/epp_build/36/download/20100910-1651/20100910-1651_eclipse-php-helios-SR1-RC3-win32.win32.x86.zip
Comment 8 Silver Zachara CLA 2010-10-12 07:29:18 EDT 
Hi,

great I can't reproduce this problem in latest M build, thank you guys
Comment 9 Roy Ganor CLA 2010-10-12 08:34:40 EDT 
per sNop comment