Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323853 - GeneratorNode cannot handle version
Summary: GeneratorNode cannot handle version
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Buckminster (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: buckminster.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-27 12:05 EDT by Carsten Reckord CLA
Modified: 2019-02-25 14:41 EST (History)
1 user (show)

See Also:

Attachments
Patch for wrong version range (746 bytes, patch)
2010-08-27 12:06 EDT, Carsten Reckord CLA 		no flags Details | Diff
Updated patch (1.09 KB, patch)
2010-09-03 10:05 EDT, Carsten Reckord CLA 		thomas: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Reckord CLA 2010-08-27 12:05:10 EDT 
If a version is set for a generator node, resolution attempts fail with 

java.lang.IllegalArgumentException: Range minimum "1.6.0.21" is not less then range maximum "1.6.0.21" (inclusion is required at both ends if the versions are equal)
at org.eclipse.equinox.p2.metadata.VersionRange.validateRange(VersionRange.java:467)
at org.eclipse.equinox.p2.metadata.VersionRange.<init>(VersionRange.java:96)
at org.eclipse.buckminster.core.metadata.model.GeneratorNode.getRequest(GeneratorNode.java:109)
Comment 1 Carsten Reckord CLA 2010-08-27 12:06:48 EDT 
Created attachment 177628 [details]
Patch for wrong version range

The GeneratorNode creates the version range as [x.x.x,x.x.x). The attached patch changes this to [x.x.x,x.x.x], which should fix this problem.
Comment 2 Carsten Reckord CLA 2010-09-03 10:05:29 EDT 
Created attachment 178150 [details]
Updated patch

A followup problem is that the property names for the generator element's version and name got mixed up. I updated the patch to fix that, too.
Comment 3 Thomas Hallgren CLA 2010-09-11 06:12:07 EDT 
Patch applied to helios-maintenance rev 11579.
Comment 4 Thomas Hallgren CLA 2010-09-11 06:12:45 EDT 
Comment on attachment 178150 [details]
Updated patch

Thanks for the patch.