Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323791 - [DB] Column comment in cdo_commit_infos
Summary: [DB] Column comment in cdo_commit_infos
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.net4j.db (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Stefan Winkler CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-27 04:37 EDT by David Hein CLA
Modified: 2011-06-23 03:39 EDT (History)
1 user (show)

See Also:


Attachments
Patch (1.03 KB, patch)
2010-08-27 04:58 EDT, Stefan Winkler CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Hein CLA 2010-08-27 04:37:59 EDT
Build Identifier: 20100617-1415

Hi,

I'am trying to implement the Oracle DBAdapter like in the bundle org.eclipse.net4j.db.mysql. I integrated the jdbc driver into my bundle. All works fine. Now the framework will create the tables in the database.

While executing the SQL-String

"CREATE TABLE cdo_commit_infos (commit_time NUMBER, branch_id INTEGER, user_id VARCHAR(255), comment VARCHAR(255))"

i got an exception with the message "ORA-00904: string: invalid identifier". The problem is, that the table contains the coloumn "comment". And "comment" is a reserved word in oracle. I found the defintion of this coloumn in the class CDODBSchema:

public static final IDBField COMMIT_INFOS_COMMENT = //
  COMMIT_INFOS.addField("comment", DBType.VARCHAR); //$NON-NLS-1$

Can this "comment" field be renamed to "commit_comment"?

Thank You!
David 

Reproducible: Always
Comment 1 Stefan Winkler CLA 2010-08-27 04:58:31 EDT
Created attachment 177595 [details]
Patch

does the rename
Comment 2 Stefan Winkler CLA 2010-08-30 10:55:10 EDT
committed to HEAD
Comment 3 Eike Stepper CLA 2011-06-23 03:39:40 EDT
Available in R20110608-1407