Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323775 - LibraryFacetPropertyPage doesn't commit changes on OK after trip to facets page
Summary: LibraryFacetPropertyPage doesn't commit changes on OK after trip to facets page
Status: RESOLVED WORKSFORME
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 20:46 EDT by Paul Fullbright CLA
Modified: 2010-09-02 14:05 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Fullbright CLA 2010-08-26 20:46:16 EDT 
This can best be seen on the JPA properties page.  
- Open the properties on a JPA project that uses a User Library provider.
- Go to the facets page and change the facets (using 'Apply').
- Go back to the JPA properties page.
- Change the particular library used.
- Commit with 'OK'
- The library is not actually changed.

This does not happen when skipping the side trip to the facets page, it does not happen without first populating the JPA properties page, and it does not happen when 'Apply' is used to commit the library change.

It seems there is an extra refresh() done on the LibraryInstallDelegate which ends up re-init()-ing the library install config, and throwing away the UI changes.
Comment 1 Konstantin Komissarchik CLA 2010-09-01 18:47:24 EDT 
Will take a look at this scenario.
Comment 2 Konstantin Komissarchik CLA 2010-09-02 11:34:34 EDT 
I am not reproducing what you are seeing. I am able to apply facet changes then go to jpa page change the library and have the changes stick after ok.
Comment 3 Paul Fullbright CLA 2010-09-02 14:05:45 EDT 
Are you populating the JPA facets page, THEN changing the facets, THEN going back and changing the library configuration?