Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323732 - An unnecessary error in the error log appears when a closed remote C/C++ project is deleted
Summary: An unnecessary error in the error log appears when a closed remote C/C++ proj...
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 4.0.3   Edit
Assignee: Chris Recoskie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 13:10 EDT by Michael Lindo CLA
Modified: 2010-08-26 14:55 EDT (History)
2 users (show)

See Also:

Attachments
A proposed fix - don't call hasRemoteNature (1.14 KB, patch)
2010-08-26 13:52 EDT, Michael Lindo CLA 		recoskie: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Lindo CLA 2010-08-26 13:10:02 EDT 
Build Identifier: 

The error "Project x is not open." appears in the error log when a closed remote C/C++ project is deleted. 



Reproducible: Always

Steps to Reproduce:
1. Create a remote C/C++ project
2. Close the project
3. Delete the project
4. Check the error log view for the error message "Project x is not open."
Comment 1 Michael Lindo CLA 2010-08-26 13:52:18 EDT 
Created attachment 177548 [details]
A proposed fix - don't call hasRemoteNature

No longer check if the resource "hasRemoteNature" which will consequently stop the error from happening.

hasRemoteNature may incorrectly return false if the resource is inaccessible (closed).  This is because the hasNature method calls checkAccessible before it returns the nature. Just because the resource is inaccessible doesn't necessarily mean it is not remote. 

The end result is "projectStatusMap.remove(projectName)" will return null on a non remote nature project, which should not be a problem.
Comment 2 Chris Recoskie CLA 2010-08-26 14:25:14 EDT 
Comment on attachment 177548 [details]
A proposed fix - don't call hasRemoteNature

Patch looks fine, I'll see about committing it today/tomorrow.
Comment 3 Chris Recoskie CLA 2010-08-26 14:55:55 EDT 
Committed to ptp_4_0 and HEAD.