Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323689 - refactoring operations need an entry point to put operations at the very end
Summary: refactoring operations need an entry point to put operations at the very end
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Bozier jerome CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: adopter
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-26 05:28 EDT by Bozier jerome CLA
Modified: 2016-05-05 10:30 EDT (History)
2 users (show)

See Also:
paulslau: review+


Attachments
patch (3.34 KB, patch)
2010-09-03 07:03 EDT, Bozier jerome CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bozier jerome CLA 2010-08-26 05:28:53 EDT
user product have proxy node that use EMF framework
when trying to update theses proxy that reference resources, all resource must have finished their physical action to be in good location with good name (EMF often load theses resource to update the model)
so, we need an entry point so that theses update operations can be run when all resources are physically copied/pasted/moved/renamed

inside TPTP, theses "final" update are performed inside a general EMFRefactoringTransaction. this mechanism is totally internal and closed to user product.
we have to add an extension point mechanism so that user can declare their own final actions to be performed
Comment 1 Alex Bernstein CLA 2010-08-27 12:59:32 EDT
We need to fix this. This is important.
Comment 2 Bozier jerome CLA 2010-09-03 07:03:26 EDT
Created attachment 178129 [details]
patch

this patch add new API for EMFRefactoringTransaction

it add theses 2 methods :
. public void addCustomChange(Change change)
=> allow user to add a custom change

. public List<Change> getCustomChanges()
=> allow user to retrieve the list of all custom change

theses custom change will be performed at end of EMFRefactoringTransaction commit part
with theses entry points, user that have their own EMF change to be performed to update their EMF model when all physical change have already been done (so that any resource loading made by EMF will not fail)
Comment 3 Bozier jerome CLA 2010-09-03 07:04:08 EDT
Paul, could you please review this small patch ?

many thanks to you
Comment 4 Paul Slauenwhite CLA 2010-09-03 07:23:16 EDT
Reviewed and approved with comments:

-Please make the new methods @provisional.
Comment 5 Paul Slauenwhite CLA 2010-09-10 14:40:50 EDT
Note, this may have been resolved by defect 324996.  Please confirm.
Comment 6 Bozier jerome CLA 2010-10-11 06:24:56 EDT
324996 is necessary but not enough, we have to deliver also this patch
Comment 7 Bozier jerome CLA 2010-10-26 10:40:00 EDT
patch pushed under 4.7.2 CVS

closing
Comment 8 Kathy Chan CLA 2011-02-11 13:46:01 EST
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 9 Bozier jerome CLA 2011-04-04 09:41:05 EDT
closing