Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323648 - SSH Terminals subsystem should re-use user id and password for the Files subsystem
Summary: SSH Terminals subsystem should re-use user id and password for the Files subs...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-25 15:46 EDT by Ankit Pasricha CLA
Modified: 2010-08-26 11:46 EDT (History)
4 users (show)

See Also:
kjdoyle: review+
ddykstal.eclipse: review+


Attachments
patch to propagate the password to other connector services (1.19 KB, patch)
2010-08-25 15:48 EDT, David McKnight CLA
no flags Details | Diff
updated patch with author update (2.17 KB, patch)
2010-08-25 15:50 EDT, David McKnight CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ankit Pasricha CLA 2010-08-25 15:46:51 EDT
I have my own connection that includes the Files and SSH Terminals subsystem. When I connect at the system level, I get 2 prompts - one for the Files subsystem and another for the SSH Terminals subsystem. I should only get one prompt.
Comment 1 David McKnight CLA 2010-08-25 15:48:14 EDT
The problem is that we're not propagating the password across to other connector services within the same connection.
Comment 2 David McKnight CLA 2010-08-25 15:48:37 EDT
Created attachment 177470 [details]
patch to propagate the password to other connector services
Comment 3 David McKnight CLA 2010-08-25 15:50:39 EDT
Created attachment 177471 [details]
updated patch with author update
Comment 4 David McKnight CLA 2010-08-25 15:51:33 EDT
Kevin, could you review this patch?  Thanks.
Comment 5 David McKnight CLA 2010-08-25 16:01:22 EDT
Note this isn't an ssh terminals issue - it's more generally related to multiple connector services under a single host.
Comment 6 David Dykstal CLA 2010-08-25 16:09:36 EDT
We don't necessarily want to blindly propagate or use the authorization information. There are some services, such as FTP, that might use different credentials even though they are at the same host address.
Comment 7 David McKnight CLA 2010-08-25 16:18:49 EDT
(In reply to comment #6)
> We don't necessarily want to blindly propagate or use the authorization
> information. There are some services, such as FTP, that might use different
> credentials even though they are at the same host address.

That's a fair point although I believe we do reuse the credentials for all connector services within a connection when the user elects to save them.  I'd probably create a separate connection for cases where I use different credentials.
Comment 8 David McKnight CLA 2010-08-25 16:24:54 EDT
Adding Dave D to the reviewers since he's got concerns here.
Comment 9 Ankit Pasricha CLA 2010-08-25 19:58:57 EDT
In response to Dave Dykstal's comment - In a majority of cases, I would imagine that the user has a single user ID and password to a single system. I do not think RSE's behaviour should support the minority scenario by default.
Comment 10 David Dykstal CLA 2010-08-26 09:19:41 EDT
As long as we have a mechanism (in this case alternate connections) for saving credentials then I seen no problem with sharing these credentials among all connector services.
Comment 11 Kevin Doyle CLA 2010-08-26 11:29:40 EDT
I'm okay with this as well.
Comment 12 David McKnight CLA 2010-08-26 11:46:17 EDT
Thanks for the reviews.  I've committed the change to cvs.