This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 323646 - Version is missing in artifact files
Summary: Version is missing in artifact files
Status: RESOLVED FIXED
Alias: None
Product: Tigerstripe (Archived)
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.5M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-25 15:39 EDT by Navid Mehregani CLA
Modified: 2010-10-22 14:25 EDT (History)
2 users (show)

See Also:


Attachments
proposed_patch_323646.txt (967 bytes, patch)
2010-10-21 16:02 EDT, Daniel Johnson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Navid Mehregani CLA 2010-08-25 15:39:03 EDT
Build Identifier: 

This defect seems to be a regression as it seems to work fine in older versions of Tigerstripe.

Create a new artifact, switch to the source page in the artifact's editor.  Notice the following in its header:

/*******************************************************************************
 * Created with Tigerstripe(tm) Workbench v.$runtime.getProperty("tigerstripe.feature.version")
 * Copyright (c) 2007 Cisco Systems, Inc.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 *
 * DO NOT EDIT THIS FILE - Created with Tigerstripe(tm) Workbench
 *
 *******************************************************************************/


The version is displayed as v.$runtime.getProperty("tigerstripe.feature.version").  In the past, the correct TS version would be displayed in an artifact's header.

Reproducible: Always
Comment 1 Daniel Johnson CLA 2010-10-19 18:06:40 EDT
The reason the version no longer shows up is because the install.properties file can not be found where it is expected. By adding a call to createPropertiesFileForHeadlessRun in the run method of PostInstallActions this bug is fixed. Can anyone tell me if this is an ok solution, or if this could break things down the road?
Comment 2 Daniel Johnson CLA 2010-10-21 16:02:55 EDT
Created attachment 181446 [details]
proposed_patch_323646.txt

I am not sure if this is the correct way...Eric left a comment in January 2009 saying he thinks the method I am calling should be removed. I could not find another method that seemed to do the same thing though...
Comment 3 Navid Mehregani CLA 2010-10-22 14:25:23 EDT
Thanks Dan, I reviewed and submitted your patch.
With the way this is setup, the version displayed in newly created artifacts will be extracted from the plugin version of org.eclipse.tigerstripe.workbench.base.  We have to ensure that this plugin version is updated for each TS release.