Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323611 - [TMF] TmfVirtualTable scrolling and slider bugs
Summary: [TMF] TmfVirtualTable scrolling and slider bugs
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Francois Chouinard CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 301637
  Show dependency tree
 
Reported: 2010-08-25 09:42 EDT by François Godin CLA
Modified: 2022-01-13 14:53 EST (History)
0 users

See Also:


Attachments
Patch (1.63 KB, patch)
2010-08-25 09:51 EDT, François Godin CLA
no flags Details | Diff
Patch v2 (1.82 KB, patch)
2010-08-26 13:18 EDT, François Godin CLA
fchouinard: iplog+
Details | Diff
TmfVirtualTable patch (14.20 KB, patch)
2010-09-12 14:55 EDT, Francois Chouinard CLA
fchouinard: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description François Godin CLA 2010-08-25 09:42:10 EDT
Build Identifier: 

If you use the mouse wheel to scroll you may not be able to get to the first or last event depending on the size of the table. 

Also, if you get the slider to get at the end of the table. The last ten events are visible. The cells that may be after do not get changed.

Reproducible: Always
Comment 1 François Godin CLA 2010-08-25 09:51:36 EDT
Created attachment 177421 [details]
Patch

This patch change the calculation of the number of rows in the table by taking the true height of the table. Thus correcting the mouse wheel scroll bug.
It also change the thumb size of the slider from 10 to the number of rows.
Comment 2 François Godin CLA 2010-08-26 13:18:31 EDT
Created attachment 177543 [details]
Patch v2

Corrected a bug on the resize of the view when at the end of the trace.
Comment 3 Francois Chouinard CLA 2010-08-30 16:11:05 EDT
Comment on attachment 177543 [details]
Patch v2

Patch committed
Comment 4 Francois Chouinard CLA 2010-09-12 14:55:42 EDT
Created attachment 178704 [details]
TmfVirtualTable patch

This patch provides a number of enhancements to the TmfVirtualTable:

[1] It uses a layout to let the virtual table and associate slider compute their size automatically; the slider is left to its default width; the layout margin height is set to 0.

[2] It correctly handles the table when the number of items is less than the number of rows. It also correctly handles the scrolling when a row is partially displayed.

[3] The table selection is updated and displayed. It also correctly triggers the time synchronization signal for the other views.
Comment 5 Francois Chouinard CLA 2010-09-12 15:09:38 EDT
Fix committed to Helios and Indigo.
Comment 6 Francois Chouinard CLA 2010-09-12 17:14:28 EDT
Resolved.
Comment 7 Francois Chouinard CLA 2011-07-22 14:47:58 EDT
Delivered with 0.7