Community
Participate
Working Groups
Build Identifier: I20100608-0911 The representation of diagrams can be improved. The selection window bottom edge is invisible. The draw method redraw (new image canvas) histogram on each draw event. We can store the image when the trace parsing is completed. Reproducible: Always Steps to Reproduce: 1. The selection windows is always visible and you can see the hidden bottom edge.
Created attachment 177323 [details] The Histogram design and draw corrections The isFinished flag has been added to be able to determine the end of the request parsing. This improvement gives the optimization on redraw event after the end of request parsing because we use the saved image instead the full regeneration. The using of standard SWT colors from HistogramConstant has been changed to using inline RGB color. The graph and the selection window border colors have been changed to more relax colors. The selection window has been filled-up using transparency and the square rectangle has been changed to rounded rectangle. It looks more attractive. The cross-hair representation has been changed.
I do some performance tests. Its complicated to do the exact measurements because we using the threads priorities. It's not official time measuring it's only first approach to determine the results of draw optimizations. In the graphs the each line is a time spended to one redraw event. 1) I just open one experiment. original patched 118,195 118,480 77,437 100,193 78,355 40,080 1,895,820 2,299,436 3,042,738 235,084 ========================= 5,212,545 2,793,273 (SUM) We can see the similar time except the 2 last lines. We have improvement of 2,419,272 in total. 2) I open the experiment and I do minimize/maximize event 3 times. original patched 119,606 121,920 72,759 72,958 99,076 52,232 1,340,036 2,893,396 3,407,458 244,822 ========================= 5,038,935 3,385,328 (SUM) 43,732 629,782 13,502,639 220,415 845,962 315,402 ========================= 4,797,444 388,533 (AVG) The 5 first events have the similar diagnose as in prior test. The redraw method gives the more liniar result during the minimize/maximize event. We have improvement of 6,062,518 in total (1,653,607 for startup time and 4,408,911 for minimize/maximize events). 3) After the loading of experiment I just move the selection window with random speed and direction. original patched 715,776 146,409 624,370 240,609 663,413 2,236,466 332,685 1,426,687 765,685 295,253 718,242 154,006 633,743 138,249 606,428 367,668 661,062 143,986 498,048 139,152 1,471,446 757,350 625,306 139,733 692,101 144,726 660,173 2 928,151 165,831 1,195,769 172,554 6,528,891 200,553 1,157,104 155,134 870,001 183,395 1,734,943 53,835 797,582 136,336 1,550,722 278,917 1,177,704 151,645 1,434,994 215,304 1,359,350 307,554 1,184,427 257,886 1,204,964 317,590 1,089,075 267,249 1,287,425 211,020 1,024,574 199,415 1,362,331 161,644 3,581,868 245,193 18,454,028 201,250 1,843,095 261,790 3,998,234 214,230 1,117,661 383,404 1,594,232 215,835 668,863 145,021 565,498 186,216 597,588 172,224 559,187 229,873 1,174,758 159,526 781,920 206,712 750,875 208,859 659,764 215,313 910,249 231,027 755,227 691,748 764,201 209,342 655,309 148,077 622,345 132,384 1,042,543 238,737 629,642 134,663 794,162 198,036 743,518 204,624 1,804,508 208,506 634,895 343,366 1,385,418 209,899 603,645 209,479 874,815 211,026 664,499 207,784 667,242 215,774 1,243,773 192,224 659,003 207,554 655,144 211,447 645,249 287,968 641,967 215,912 781,554 208,449 639,046 146,022 348,043 210,193 865,680 197,569 300,684 491,115 954,012 847,646 710,325 132,159 684,663 263,526 1,202,690 210,241 5,461,076 210,733 1,194,967 194,227 593,986 218,346 810,952 171,778 964,332 138,255 588,058 223,979 654,203 157,567 831,779 207,266 462,634 858,350 631,955 215,323 816,454 208,703 665,495 181,239 1,261,559 188,506 802,960 138,381 1,306,509 142,040 778,281 664,625 759,263 221,907 629,632 203,532 647,076 356,646 1,937,246 372,048 5,447,126 375,617 590,293 418,490 499,384 293,642 834,608 381,917 560,628 3,835,526 574,005 449,753 652,932 210,598 654,548 521,285 2,963,442 208,286 1,851,335 195,065 1,190,259 150,123 1,827,715 1,098,746 1,243,941 261,077 1,579,382 543,288 1,950,428 3,434,376 1,431,923 550,559 1,427,027 2,275,144 2,523,323 746,742 1,178,812 950,791 1,492,861 408,871 657,907 208,723 847,074 18,321 620,465 360,636 645,056 234,450 1,333,074 262,234 690,215 311,306 620,258 290,468 761,124 264,044 675,386 266,398 687,047 197,907 2,844,671 214,250 1,266,734 843,380 649,896 186,476 755,542 367,223 709,685 408,711 817,495 197,376 1,590,758 197,562 2,277,472 360,326 661,171 353,009 931,241 208,363 722,237 152,668 1,496,330 373,882 666,976 206,574 700,549 206,250 574,626 209,529 678,813 172,261 246,805 231,833 671,501 209,546 943,125 287,583 680,549 212,419 658,891 155,316 634,982 279,745 903,250 237,333 5,958,981 208,027 466,136 268,819 663,240 214,700 1,731,612 221,645 1,261,123 151,473 1,328,502 207,736 425,750 250,950 1,030,761 152,971 1,487,633 233,078 1,631,661 332,519 3,996,337 393,273 1,031,060 384,942 1,218,781 260,715 1,198,713 209,635 1,271,160 367,813 1,238,006 213,608 2,063,463 207,096 684,384 242,303 734,652 261,860 661,197 200,400 1,118,175 331,130 1,122,104 200,328 1,108,553 252,614 1,059,866 356,665 664,628 159,501 655,776 233,904 762,966 207,958 889,880 218,964 717,235 258,642 712,350 216,986 2,459,770 162,018 685,161 235,165 994,279 194,508 1,594,012 766,343 817,833 412,200 722,713 332,891 749,370 197,961 706,697 197,240 2,609,230 210,605 795,384 323,933 1,149,650 598,299 705,616 214,771 1,040,771 208,566 1,021,377 245,327 705,099 321,175 702,119 181,278 12,413,641 196,460 690,693 204,682 969,022 700,688 911,180 261,128 2,115,658 190,898 829,577 132,771 3,305,020 167,123 2,952,004 129,476 932,538 127,483 141,597 361,895 956,167 320,909 6,347,055 251,310 8,381,381 174,494 708,857 238,041 1,714,249 233,239 723,693 196,880 762,982 224,948 1,143,857 278,165 1,142,452 208,260 754,506 144,231 718,599 208,306 698,970 434,116 764,471 220,549 3,887,564 232,345 782,912 196,718 619,049 229,557 1,175,547 367,190 692,923 323,011 788,165 272,585 713,276 299,617 715,415 1,260,875 649,562 262,463 793,644 328,360 706,442 473,293 603,480 208,693 748,163 331,321 702,203 526,210 708,854 616,788 614,245 645,512 700,253 485,454 717,444 8,637,462 659,727 478,340 503,440 448,763 690,407 472,930 797,954 504,821 705,484 407,907 720,769 295,620 1,530,831 370,366 657,960 264,388 576,445 261,165 979,342 203,612 718,897 196,607 709,202 207,043 694,359 208,131 667,031 306,648 777,813 220,273 708,521 211,268 687,255 211,463 664,885 211,212 688,261 231,201 673,164 205,050 681,215 861,890 663,589 521,194 439,109 198,464 1,413,937 199,582 747,802 209,554 676,148 358,579 1,332,442 423,697 280,405 528,380 688,247 422,384 785,254 531,978 493,434 526,967 754,530 768,779 661,051 232,643 764,596 132,419 342,766 131,197 915,574 256,519 409,733 133,122 661,506 145,650 702,795 129,014 687,015 266,772 849,612 195,619 713,288 294,830 824,601 327,561 357,667 495,422 720,780 195,925 1,528,327 313,269 262,277 534,292 63,307,108 506,708 2,036,602 3,831,535 742,994 229,550 1,023,682 349,586 714,812 325,480 5,527,285 350,269 880,881 308,830 713,335 204,042 688,524 132,271 531,628 259,655 687,392 395,106 ========================= 1,404,287 366,448 (AVG) We can see that the draw method takes less times on selection window moving. We have improvements of 1,037,840 for each event in average.
Comment on attachment 177323 [details] The Histogram design and draw corrections Fix committed in Indigo branch.
Completed. Thanks Yuriy.
One small thing: I kept the progressive drawing of the "long" histogram. I use it as an expensive progress bar. It can be easily removed if performance requires it.
Delivered with 0.7
