Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323436 - SelectionProviderStrategies cannot guarentee order
Summary: SelectionProviderStrategies cannot guarentee order
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: JSF Tools (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Gerry Kessler CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-23 15:57 EDT by Gerry Kessler CLA
Modified: 2010-08-31 21:57 EDT (History)
2 users (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
raghunathan.srinivasan: pmc_approved? (deboer)
raghunathan.srinivasan: pmc_approved? (neil.hauge)
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: pmc_approved? (raghunathan.srinivasan)
raghunathan.srinivasan: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerry Kessler CLA 2010-08-23 15:57:24 EDT 
This bug was split out from bug 321039.

Can't guarantee the extended LocatorProvider will be picked up each time 
   In the CompositeFactorySelectionStrategyProvider.getFactoryToUse() method in
JSFAppConfigManagerFactory.java, it calls providerSelector.perform(project)
method. In the perform() method, it uses an iterator for a HashMap to find the
first LocatorProvider. If DefaultJSFAppConfigManagerProviderStrategy is
searched before ExtensionBasedJSFAppConfigManagerProviderStrategy, the
DefaultProvider instead of my extended LocatorProvider will be returned.
Comment 1 Gerry Kessler CLA 2010-08-24 13:35:05 EDT 
Checked into HEAD (3.2.2 and 3.3)
Comment 2 Raghunathan Srinivasan CLA 2010-08-27 14:31:22 EDT 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
See description
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
None
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Manual
* Give a brief technical overview. Who has reviewed this fix? 
See description
* What is the risk associated with this fix? 
none-low
Comment 3 Raghunathan Srinivasan CLA 2010-08-27 14:31:51 EDT 
This failed to make this week's build because of spurious junit failures in
local testing.